[Extensions UI] Handle multiple warning bubbles racing to show

[Extensions UI] Handle multiple warning bubbles racing to show

If multiple windows all tried to create a warning bubble at the same
time, it would be handled incorrectly. Though only one bubble would
show, the others would be destructed and potentially undo the work the
first did (like highlighting extensions on the toolbar).

Instead, link the warning bubbles with the toolbar model, which is per-
profile and handles the highlighting logic. Also add a regression test,
and beef up some existing tests.

BUG=620434
Review-Url: https://codereview.chromium.org/2076093004
Cr-Commit-Position: refs/heads/master@{#400849}
(cherry picked from commit af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1)

[Extensions UI] Fix a crash when clicking on a bubble's learn more

Clicking on a bubble's learn more link causes a tab to open, which in
turn causes the bubble to be cleaned up (as part of losing focus to the
new tab). Fix the order so that we clean up before opening the new tab
and add a regression test. Also add end-to-end tests for clicking on the
action and dismiss buttons.

BUG=622117
Review-Url: https://codereview.chromium.org/2086193002
Cr-Commit-Position: refs/heads/master@{#401412}
(cherry picked from commit bb826f1bd289d9147c4e0b630831b0ab6ae81afd)

TBR=avi@chromium.org
TBR=finnur@chromium.org

Manual Merge Note: Merging the fix for crbug.com/620434 along with the
fix for the crash related to that patch.

Committed: https://chromium.googlesource.com/chromium/src/+/182a245e61779ac581e91c5ddb6841fb76595f01

[Devlin, 2016-06-29 17:13:41]

Description was changed from

==========
[Extensions UI] Handle multiple warning bubbles racing to show

If multiple windows all tried to create a warning bubble at the same
time, it would be handled incorrectly. Though only one bubble would
show, the others would be destructed and potentially undo the work the
first did (like highlighting extensions on the toolbar).

Instead, link the warning bubbles with the toolbar model, which is per-
profile and handles the highlighting logic. Also add a regression test,
and beef up some existing tests.

BUG=620434

Review-Url: https://codereview.chromium.org/2076093004
Cr-Commit-Position: refs/heads/master@{#400849}
(cherry picked from commit af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1)

[Extensions UI] Fix a crash when clicking on a bubble's learn more

Clicking on a bubble's learn more link causes a tab to open, which in
turn causes the bubble to be cleaned up (as part of losing focus to the
new tab). Fix the order so that we clean up before opening the new tab
and add a regression test. Also add end-to-end tests for clicking on the
action and dismiss buttons.

BUG=622117

Review-Url: https://codereview.chromium.org/2086193002
Cr-Commit-Position: refs/heads/master@{#401412}
(cherry picked from commit bb826f1bd289d9147c4e0b630831b0ab6ae81afd)

Manual Merge Note: Merging the fix for crbug.com/620434 along with the
fix for the crash related to that patch.
==========

to

==========
[Extensions UI] Handle multiple warning bubbles racing to show

If multiple windows all tried to create a warning bubble at the same
time, it would be handled incorrectly. Though only one bubble would
show, the others would be destructed and potentially undo the work the
first did (like highlighting extensions on the toolbar).

Instead, link the warning bubbles with the toolbar model, which is per-
profile and handles the highlighting logic. Also add a regression test,
and beef up some existing tests.

BUG=620434

Review-Url: https://codereview.chromium.org/2076093004
Cr-Commit-Position: refs/heads/master@{#400849}
(cherry picked from commit af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1)

[Extensions UI] Fix a crash when clicking on a bubble's learn more

Clicking on a bubble's learn more link causes a tab to open, which in
turn causes the bubble to be cleaned up (as part of losing focus to the
new tab). Fix the order so that we clean up before opening the new tab
and add a regression test. Also add end-to-end tests for clicking on the
action and dismiss buttons.

BUG=622117

Review-Url: https://codereview.chromium.org/2086193002
Cr-Commit-Position: refs/heads/master@{#401412}
(cherry picked from commit bb826f1bd289d9147c4e0b630831b0ab6ae81afd)

TBR=avi@chromium.org
TBR=finnur@chromium.org

Manual Merge Note: Merging the fix for crbug.com/620434 along with the
fix for the crash related to that patch.
==========

[Devlin, 2016-06-29 17:17:59]

Description was changed from

==========
[Extensions UI] Handle multiple warning bubbles racing to show

If multiple windows all tried to create a warning bubble at the same
time, it would be handled incorrectly. Though only one bubble would
show, the others would be destructed and potentially undo the work the
first did (like highlighting extensions on the toolbar).

Instead, link the warning bubbles with the toolbar model, which is per-
profile and handles the highlighting logic. Also add a regression test,
and beef up some existing tests.

BUG=620434

Review-Url: https://codereview.chromium.org/2076093004
Cr-Commit-Position: refs/heads/master@{#400849}
(cherry picked from commit af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1)

[Extensions UI] Fix a crash when clicking on a bubble's learn more

Clicking on a bubble's learn more link causes a tab to open, which in
turn causes the bubble to be cleaned up (as part of losing focus to the
new tab). Fix the order so that we clean up before opening the new tab
and add a regression test. Also add end-to-end tests for clicking on the
action and dismiss buttons.

BUG=622117

Review-Url: https://codereview.chromium.org/2086193002
Cr-Commit-Position: refs/heads/master@{#401412}
(cherry picked from commit bb826f1bd289d9147c4e0b630831b0ab6ae81afd)

TBR=avi@chromium.org
TBR=finnur@chromium.org

Manual Merge Note: Merging the fix for crbug.com/620434 along with the
fix for the crash related to that patch.
==========

to

==========
[Extensions UI] Handle multiple warning bubbles racing to show

If multiple windows all tried to create a warning bubble at the same
time, it would be handled incorrectly. Though only one bubble would
show, the others would be destructed and potentially undo the work the
first did (like highlighting extensions on the toolbar).

Instead, link the warning bubbles with the toolbar model, which is per-
profile and handles the highlighting logic. Also add a regression test,
and beef up some existing tests.

BUG=620434

Review-Url: https://codereview.chromium.org/2076093004
Cr-Commit-Position: refs/heads/master@{#400849}
(cherry picked from commit af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1)

[Extensions UI] Fix a crash when clicking on a bubble's learn more

Clicking on a bubble's learn more link causes a tab to open, which in
turn causes the bubble to be cleaned up (as part of losing focus to the
new tab). Fix the order so that we clean up before opening the new tab
and add a regression test. Also add end-to-end tests for clicking on the
action and dismiss buttons.

BUG=622117

Review-Url: https://codereview.chromium.org/2086193002
Cr-Commit-Position: refs/heads/master@{#401412}
(cherry picked from commit bb826f1bd289d9147c4e0b630831b0ab6ae81afd)

TBR=avi@chromium.org
TBR=finnur@chromium.org

Manual Merge Note: Merging the fix for crbug.com/620434 along with the
fix for the crash related to that patch.

Committed:
https://chromium.googlesource.com/chromium/src/+/182a245e61779ac581e91c5ddb68...
==========

[Devlin, 2016-06-29 17:18:01]

Committed patchset #1 (id:1) manually as
182a245e61779ac581e91c5ddb6841fb76595f01 (presubmit successful).