Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 2086193002: [Extensions UI] Fix a crash when clicking on a bubble's learn more (Closed)

Created:
4 years, 6 months ago by Devlin
Modified:
4 years, 6 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions UI] Fix a crash when clicking on a bubble's learn more Clicking on a bubble's learn more link causes a tab to open, which in turn causes the bubble to be cleaned up (as part of losing focus to the new tab). Fix the order so that we clean up before opening the new tab and add a regression test. Also add end-to-end tests for clicking on the action and dismiss buttons. BUG=622117 TBR=avi@chromium.org (small changes to cocoa browsertest) Committed: https://crrev.com/bb826f1bd289d9147c4e0b630831b0ab6ae81afd Cr-Commit-Position: refs/heads/master@{#401412}

Patch Set 1 : ready #

Patch Set 2 : Fix Views clicking #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -1 line) Patch
M chrome/browser/extensions/extension_message_bubble_controller.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm View 5 chunks +54 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/extension_message_bubble_browsertest.h View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc View 1 2 chunks +60 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc View 1 5 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Devlin
Finnur, mind taking a look? One of those awesome 1-line fix, 150+ lines of tests ...
4 years, 6 months ago (2016-06-22 01:38:17 UTC) #4
Finnur
LGTM
4 years, 6 months ago (2016-06-22 10:36:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086193002/60001
4 years, 6 months ago (2016-06-22 20:09:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 6 months ago (2016-06-22 21:30:28 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 21:34:04 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bb826f1bd289d9147c4e0b630831b0ab6ae81afd
Cr-Commit-Position: refs/heads/master@{#401412}

Powered by Google App Engine
This is Rietveld 408576698