Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2105273002: Revert of [heap] Optimize ArrayBuffer tracking (Closed)

Created:
4 years, 5 months ago by Michael Lippautz
Modified:
4 years, 5 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Optimize ArrayBuffer tracking (patchset #5 id:80001 of https://codereview.chromium.org/2107443002/ ) Reason for revert: Seems to break GPU bots Original issue's description: > [heap] Optimize ArrayBuffer tracking > > With the current approach we only need to track using an unordered set as we can > still access the backing store pointer and length by the time we free the > backing store. > > BUG=chromium:619491, chromium:611688 > LOG=N > R=ulan@chromium.org > > Committed: https://crrev.com/8d2ae27808f047ca8b8f90e63a9c8735321d2ad0 > Cr-Commit-Position: refs/heads/master@{#37318} TBR=ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:619491, chromium:611688 Committed: https://crrev.com/0e1eaec71d5c6d05169308a71eaa51571e7c4f70 Cr-Commit-Position: refs/heads/master@{#37358}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -30 lines) Patch
M src/heap/array-buffer-tracker.h View 5 chunks +7 lines, -6 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 3 chunks +13 lines, -16 lines 0 comments Download
M src/heap/array-buffer-tracker-inl.h View 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Lippautz
Created Revert of [heap] Optimize ArrayBuffer tracking
4 years, 5 months ago (2016-06-29 05:29:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105273002/1
4 years, 5 months ago (2016-06-29 05:29:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 05:29:35 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 05:32:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e1eaec71d5c6d05169308a71eaa51571e7c4f70
Cr-Commit-Position: refs/heads/master@{#37358}

Powered by Google App Engine
This is Rietveld 408576698