Resize the "Google G" icon to the correct (24dp) size.

Resize the "Google G" icon to the correct (24dp) size.

It was accidentally shrunk by https://codereview.chromium.org/1959163002.

This icon is only used in the Clear Browsing Data dialog.
Before: https://screenshot.googleplex.com/LhMHEjgZ4TB.png
After: https://screenshot.googleplex.com/VrtcikSjSR6.png

BUG=595580
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/22d5cdb03b4e136dd178a3effa64277999dd050e
Cr-Commit-Position: refs/heads/master@{#402861}

[msramek, 2016-06-29 09:36:12]

Description was changed from

==========
Resize the "Google G" icon to the correct (24dp) size.

It was accidentally shrunk by https://codereview.chromium.org/1959163002.

BUG=595580
==========

to

==========
Resize the "Google G" icon to the correct (24dp) size.

It was accidentally shrunk by https://codereview.chromium.org/1959163002.

BUG=595580
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[msramek, 2016-06-29 11:43:17]

Description was changed from

==========
Resize the "Google G" icon to the correct (24dp) size.

It was accidentally shrunk by https://codereview.chromium.org/1959163002.

BUG=595580
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Resize the "Google G" icon to the correct (24dp) size.

It was accidentally shrunk by https://codereview.chromium.org/1959163002.

This icon is only used in the Clear Browsing Data dialog.
Before: https://screenshot.googleplex.com/LhMHEjgZ4TB
After: https://screenshot.googleplex.com/VrtcikSjSR6

BUG=595580
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[msramek, 2016-06-29 11:43:54]

Description was changed from

==========
Resize the "Google G" icon to the correct (24dp) size.

It was accidentally shrunk by https://codereview.chromium.org/1959163002.

This icon is only used in the Clear Browsing Data dialog.
Before: https://screenshot.googleplex.com/LhMHEjgZ4TB
After: https://screenshot.googleplex.com/VrtcikSjSR6

BUG=595580
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Resize the "Google G" icon to the correct (24dp) size.

It was accidentally shrunk by https://codereview.chromium.org/1959163002.

This icon is only used in the Clear Browsing Data dialog.
Before: https://screenshot.googleplex.com/LhMHEjgZ4TB.png
After: https://screenshot.googleplex.com/VrtcikSjSR6.png

BUG=595580
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[msramek, 2016-06-29 11:44:39]

msramek@chromium.org changed reviewers:
+ michaelpg@chromium.org

[msramek, 2016-06-29 11:44:39]

Hi Michael,

please have a look!

Thanks,
Martin

[michaelpg, 2016-06-29 16:23:23]

lgtm

https://codereview.chromium.org/2105083004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/icons.html (right):

https://codereview.chromium.org/2105083004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/icons.html:14: <path fill="#4285F4" d="M22.56
12.25c0-.78-.07-1.53-.2-2.25H12v4.26h5.92c-.26 1.37-1.04 2.53-2.21
3.31v2.77h3.57c2.08-1.92 3.28-4.74 3.28-8.09z"></path>
Looks like I did shrink it, sorry! But it doesn't look like it was right to
begin with either (which is why this isn't just a straight-up revert) -- the
original itself was smaller than 24px, right?

[msramek, 2016-06-29 17:02:59]

Thanks!

https://codereview.chromium.org/2105083004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/icons.html (right):

https://codereview.chromium.org/2105083004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/icons.html:14: <path fill="#4285F4" d="M22.56
12.25c0-.78-.07-1.53-.2-2.25H12v4.26h5.92c-.26 1.37-1.04 2.53-2.21
3.31v2.77h3.57c2.08-1.92 3.28-4.74 3.28-8.09z"></path>
On 2016/06/29 16:23:23, michaelpg wrote:
> Looks like I did shrink it, sorry! But it doesn't look like it was right to
> begin with either (which is why this isn't just a straight-up revert) -- the
> original itself was smaller than 24px, right?

This <iron-iconset-svg> element defines size="24", so if I add a 24dp <g>, then
use that <g> in an <iron-icon> element, it will be exactly as large as the
<iron-icon> element (i.e. in 24:24 = 1:1 ratio). In my case, I then use CSS to
resize <iron-icon> to 16:16 (which also scales the <g> inside).

Originally, I achieved the desired 16x16 dimensions by hardcoding viewBox="0 0
16 16", width="16px", and height="16px" in this <g> element. You also removed
that in your CL, which is correct, because hardcoding the size kinda defeats the
point of SVG.

[michaelpg, 2016-06-29 17:25:56]

https://codereview.chromium.org/2105083004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/icons.html (right):

https://codereview.chromium.org/2105083004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/icons.html:14: <path fill="#4285F4" d="M22.56
12.25c0-.78-.07-1.53-.2-2.25H12v4.26h5.92c-.26 1.37-1.04 2.53-2.21
3.31v2.77h3.57c2.08-1.92 3.28-4.74 3.28-8.09z"></path>
On 2016/06/29 17:02:59, msramek wrote:
> On 2016/06/29 16:23:23, michaelpg wrote:
> > Looks like I did shrink it, sorry! But it doesn't look like it was right to
> > begin with either (which is why this isn't just a straight-up revert) -- the
> > original itself was smaller than 24px, right?
> 
> This <iron-iconset-svg> element defines size="24", so if I add a 24dp <g>,
then
> use that <g> in an <iron-icon> element, it will be exactly as large as the
> <iron-icon> element (i.e. in 24:24 = 1:1 ratio). In my case, I then use CSS to
> resize <iron-icon> to 16:16 (which also scales the <g> inside).

Ah, CSS. gotcha.

> 
> Originally, I achieved the desired 16x16 dimensions by hardcoding viewBox="0 0
> 16 16", width="16px", and height="16px" in this <g> element. You also removed
> that in your CL, which is correct, because hardcoding the size kinda defeats
the
> point of SVG.

Thanks for the explanation! I just used https://jakearchibald.github.io/svgomg/
to flatten the <g> but it looks like I screwed up somewhere in copying the
original.

[msramek, 2016-06-29 17:31:23]

Oooh, that's a nice tool :)

[msramek, 2016-06-29 17:31:30]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2016-06-29 17:33:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 17:48:59]

Description was changed from

==========
Resize the "Google G" icon to the correct (24dp) size.

It was accidentally shrunk by https://codereview.chromium.org/1959163002.

This icon is only used in the Clear Browsing Data dialog.
Before: https://screenshot.googleplex.com/LhMHEjgZ4TB.png
After: https://screenshot.googleplex.com/VrtcikSjSR6.png

BUG=595580
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Resize the "Google G" icon to the correct (24dp) size.

It was accidentally shrunk by https://codereview.chromium.org/1959163002.

This icon is only used in the Clear Browsing Data dialog.
Before: https://screenshot.googleplex.com/LhMHEjgZ4TB.png
After: https://screenshot.googleplex.com/VrtcikSjSR6.png

BUG=595580
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-06-29 17:49:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-29 17:49:38]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-29 17:52:02]

Description was changed from

==========
Resize the "Google G" icon to the correct (24dp) size.

It was accidentally shrunk by https://codereview.chromium.org/1959163002.

This icon is only used in the Clear Browsing Data dialog.
Before: https://screenshot.googleplex.com/LhMHEjgZ4TB.png
After: https://screenshot.googleplex.com/VrtcikSjSR6.png

BUG=595580
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Resize the "Google G" icon to the correct (24dp) size.

It was accidentally shrunk by https://codereview.chromium.org/1959163002.

This icon is only used in the Clear Browsing Data dialog.
Before: https://screenshot.googleplex.com/LhMHEjgZ4TB.png
After: https://screenshot.googleplex.com/VrtcikSjSR6.png

BUG=595580
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/22d5cdb03b4e136dd178a3effa64277999dd050e
Cr-Commit-Position: refs/heads/master@{#402861}
==========

[commit-bot: I haz the power, 2016-06-29 17:52:03]

Patchset 1 (id:??) landed as
https://crrev.com/22d5cdb03b4e136dd178a3effa64277999dd050e
Cr-Commit-Position: refs/heads/master@{#402861}