Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1959163002: MD Settings: use custom iconset (Closed)

Created:
4 years, 7 months ago by michaelpg
Modified:
4 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@SettingsIcons
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: use custom iconset Instead of including almost 1000 definitions from iron-icons, put the icons we're actually using in our own iconset. This CL is a net gain of 81 lines, but actually prevents chrome://md-settings from loading an additional >900 lines. BUG=605821 R=stevenjb@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8 Cr-Commit-Position: refs/heads/master@{#392839}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : rebase? #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -117 lines) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_add_device_dialog.html View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_pair_device_dialog.html View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/default_browser_page/default_browser_page.html View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/device_page.html View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/icons.html View 1 2 3 1 chunk +97 lines, -14 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_siminfo.html View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/languages_page.html View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/people_page/camera.html View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/people_page/change_picture.html View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 2 3 4 chunks +18 lines, -25 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_subpage.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_details.html View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_details_permission.html View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_list.html View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_settings_behavior.js View 1 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_settings_category.html View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/site_settings_page/site_settings_page.html View 1 2 3 10 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
michaelpg
Let me know how this looks. https://codereview.chromium.org/1959163002/diff/1/chrome/browser/resources/settings/icons.html File chrome/browser/resources/settings/icons.html (right): https://codereview.chromium.org/1959163002/diff/1/chrome/browser/resources/settings/icons.html#newcode9 chrome/browser/resources/settings/icons.html:9: <path d="M15.5 7.5V7c0-.98-.5-1.5-1.5-1.5h-.5c-.276 ...
4 years, 7 months ago (2016-05-09 19:45:22 UTC) #3
stevenjb
lgtm
4 years, 7 months ago (2016-05-10 16:22:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959163002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959163002/40001
4 years, 7 months ago (2016-05-11 01:02:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959163002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959163002/80001
4 years, 7 months ago (2016-05-11 02:27:21 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 7 months ago (2016-05-11 03:16:03 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 03:19:15 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8
Cr-Commit-Position: refs/heads/master@{#392839}

Powered by Google App Engine
This is Rietveld 408576698