Add get_latest_try_jobs_results to rietveld.py to fetch results of try jobs from rietveld

Add get_latest_try_jobs_results to rietveld.py to fetch results of try jobs from rietveld

BUG=621599
Committed: https://crrev.com/d1fd1e19c9e51b06b2a8199391bdc9a37a8ca2b0
Cr-Commit-Position: refs/heads/master@{#402915}

[raikiri, 2016-06-29 00:23:38]

raikiri@google.com changed reviewers:
+ qyearsley@chromium.org

[qyearsley, 2016-06-29 17:37:56]

Looks good!

Just got a few minor comments. Also, more comments about CL description
formatting:
 - Usually CL titles are a verb phrase saying what the CL does in present tense
-- "Add" instead of "Added".
 - "rietveld.pyto" -> "rietveld.py to"
 - You only need one blank line before the BUG= line.

https://codereview.chromium.org/2105043004/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py (right):

https://codereview.chromium.org/2105043004/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py:18:
TryJobResults = collections.namedtuple('TryJob', ('builder_name', 'result'))
Since it represents one single job's result, TryJobResult would be clearer.

https://codereview.chromium.org/2105043004/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py:85: def
get_latest_tryjob_results(issue_number, web):
In the official documentation, "try job" is two words
(https://www.chromium.org/developers/testing/try-server-usage), and elsewhere in
this file it's treated as two words (e.g. latest_try_jobs), so for consistency
this should be get_latest_try_job_results.

https://codereview.chromium.org/2105043004/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py:93: return
results
Alternatively, if you are just having builders and result numbers, and we don't
want multiple results for one builder name, it would also be fairly simple just
to return a dict of builder name to result, e.g.:

    results = {}
    for job in patchset_data['try_job_results']:
        results[job['builder']] = job['result']
    return results

Either way is OK, so whichever makes sense to you is good.

[raikiri, 2016-06-29 18:15:09]

Description was changed from

==========
Added get_latest_tryjobs_results to rietveld.pyto fetch results of tryjobs from
rietveld



BUG=621599
==========

to

==========
Add get_latest_try_jobs_results to rietveld.py to fetch results of try jobs from
rietveld

BUG=621599
==========

[raikiri, 2016-06-29 18:15:40]

I made the changes

[qyearsley, 2016-06-29 18:22:17]

On 2016/06/29 at 18:15:40, raikiri wrote:
> I made the changes

LGTM, although looking at this CL again now I think it would be good to have a
unit test method for get_latest_try_job_results -- could you add that before
submitting?

[raikiri, 2016-06-29 18:46:09]

The CQ bit was checked by raikiri@google.com

[raikiri, 2016-06-29 18:46:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
qyearsley@chromium.org
Link to the patchset: https://codereview.chromium.org/2105043004/#ps40001
(title: "add unittest")

[commit-bot: I haz the power, 2016-06-29 18:47:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 20:05:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-29 20:06:41]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-29 20:07:12]

Description was changed from

==========
Add get_latest_try_jobs_results to rietveld.py to fetch results of try jobs from
rietveld

BUG=621599
==========

to

==========
Add get_latest_try_jobs_results to rietveld.py to fetch results of try jobs from
rietveld

BUG=621599

Committed: https://crrev.com/d1fd1e19c9e51b06b2a8199391bdc9a37a8ca2b0
Cr-Commit-Position: refs/heads/master@{#402915}
==========

[commit-bot: I haz the power, 2016-06-29 20:07:13]

Patchset 3 (id:??) landed as
https://crrev.com/d1fd1e19c9e51b06b2a8199391bdc9a37a8ca2b0
Cr-Commit-Position: refs/heads/master@{#402915}