Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Issue 2105043004: Add get_latest_try_jobs_results to rietveld.py to fetch results of try jobs from rietveld (Closed)

Created:
4 years, 5 months ago by raikiri
Modified:
4 years, 5 months ago
Reviewers:
qyearsley
CC:
blink-reviews, cbentzel+watch_chromium.org, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add get_latest_try_jobs_results to rietveld.py to fetch results of try jobs from rietveld BUG=621599 Committed: https://crrev.com/d1fd1e19c9e51b06b2a8199391bdc9a37a8ca2b0 Cr-Commit-Position: refs/heads/master@{#402915}

Patch Set 1 #

Total comments: 3

Patch Set 2 : minor changes #

Patch Set 3 : add unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py View 1 2 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py View 1 2 4 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
raikiri
4 years, 5 months ago (2016-06-29 00:23:39 UTC) #2
qyearsley
Looks good! Just got a few minor comments. Also, more comments about CL description formatting: ...
4 years, 5 months ago (2016-06-29 17:37:56 UTC) #3
raikiri
I made the changes
4 years, 5 months ago (2016-06-29 18:15:40 UTC) #5
qyearsley
On 2016/06/29 at 18:15:40, raikiri wrote: > I made the changes LGTM, although looking at ...
4 years, 5 months ago (2016-06-29 18:22:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105043004/40001
4 years, 5 months ago (2016-06-29 18:47:06 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-29 20:05:49 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 20:06:41 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 20:07:13 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d1fd1e19c9e51b06b2a8199391bdc9a37a8ca2b0
Cr-Commit-Position: refs/heads/master@{#402915}

Powered by Google App Engine
This is Rietveld 408576698