Add get_latest_try_jobs_results to rietveld.py to fetch results of try jobs from rietveld

third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utility functions to communicate with Rietveld."""
 
 import collections
 import json
 import logging
 import urllib2
 
 
 _log = logging.getLogger(__name__)
 
 BASE_CODEREVIEW_URL = 'https://codereview.chromium.org/api'
 
 TryJob = collections.namedtuple('TryJob', ('builder_name', 'master_name', 'build_number'))
-
+TryJobResults = collections.namedtuple('TryJob', ('builder_name', 'result'))

[qyearsley, 2016/06/29 17:37:56]

Since it represents one single job's result, TryJobResult would be clearer.

 
 def latest_try_jobs(issue_number, builder_names, web, patchset_number=None):
     """Returns a list of TryJob objects for jobs on the latest patchset.
 
     Args:
         issue_number: A Rietveld issue number.
         builder_names: Builders that we're interested in; try jobs for only
             these builders will be listed.
         web: webkitpy.common.net.web.Web object (which can be mocked out).
         patchset_number: Use a specific patchset instead of the latest one.
@@ skipping 44 matching lines @@
         _log.error('Invalid JSON: %s' % contents)
         raise
 
 
 def _issue_url(issue_number):
     return '%s/%s' % (BASE_CODEREVIEW_URL, issue_number)
 
 
 def _patchset_url(issue_number, patchset_number):
     return '%s/%s' % (_issue_url(issue_number), patchset_number)
+
+
+def get_latest_tryjob_results(issue_number, web):

[qyearsley, 2016/06/29 17:37:56]

In the official documentation, "try job" is two words
(https://www.chromium.org/developers/testing/try-server-usage), and elsewhere in
this file it's treated as two words (e.g. latest_try_jobs), so for consistency
this should be get_latest_try_job_results.

+    url = _latest_patchset_url(issue_number, web)
+    patchset_data = _get_json(url, web)
+    results = []
+    for job in patchset_data['try_job_results']:
+        results.append(TryJobResults(
+            builder_name=job['builder'],
+            result=job['result']))
+    return results

[qyearsley, 2016/06/29 17:37:56]

Alternatively, if you are just having builders and result numbers, and we don't
want multiple results for one builder name, it would also be fairly simple just
to return a dict of builder name to result, e.g.:

    results = {}
    for job in patchset_data['try_job_results']:
        results[job['builder']] = job['result']
    return results

Either way is OK, so whichever makes sense to you is good.