chrome/renderer/resources/extensions/browser_action_custom_bindings.js - Issue 2105033003: tabId support to chrome.extensions.getViews()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/browser_action_custom_bindings.js

Issue 2105033003: tabId support to chrome.extensions.getViews() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed code review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/extension.json ('K') | « chrome/common/extensions/api/extension.json ('k') | chrome/renderer/resources/extensions/file_entry_binding_util.js » ('j') | chrome/test/data/extensions/api_test/get_views/test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/browser_action_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/browser_action_custom_bindings.js b/chrome/renderer/resources/extensions/browser_action_custom_bindings.js

index e9c3d57a788b04a97ee3f1694dd369af039ba48d..0aaa4b38379450ad6896bf1c8d3660378b7ee25c 100644

--- a/chrome/renderer/resources/extensions/browser_action_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/browser_action_custom_bindings.js

@@ -28,7 +28,7 @@ binding.registerCustomHook(function(bindingsAPI) {

if (lastError.hasError(chrome)) {

callback();

} else {

- var views = getExtensionViews(-1, 'POPUP');

+ var views = getExtensionViews(-1, 'POPUP', -1);

callback(views.length > 0 ? views[0] : null);

}

});