chrome/renderer/resources/extensions/file_entry_binding_util.js - Issue 2105033003: tabId support to chrome.extensions.getViews()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/file_entry_binding_util.js

Issue 2105033003: tabId support to chrome.extensions.getViews() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed code review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/extensions/file_entry_binding_util.js

diff --git a/chrome/renderer/resources/extensions/file_entry_binding_util.js b/chrome/renderer/resources/extensions/file_entry_binding_util.js

index a378fbaf5831ac9250435018e7fdeb087c98f708..8e70e873a86825f5128f83c8a633b36ccb00d1b9 100644

--- a/chrome/renderer/resources/extensions/file_entry_binding_util.js

+++ b/chrome/renderer/resources/extensions/file_entry_binding_util.js

@@ -18,7 +18,7 @@ var GetExtensionViews = requireNative('runtime').GetExtensionViews;

// previously saved file entries.

function getFileBindingsForApi(apiName) {

// Fallback to using the current window if no background page is running.

- var backgroundPage = GetExtensionViews(-1, 'BACKGROUND')[0] || window;

+ var backgroundPage = GetExtensionViews(-1, 'BACKGROUND', -1)[0] || window;

var backgroundPageModuleSystem = GetModuleSystem(backgroundPage);

// All windows use the bindFileEntryCallback from the background page so their