Explicitly Disallow heap allocation when wasm memory references are updated

[wasm] Explicitly Disallow heap allocation when wasm memory references are updated
 - Enable grow memory tests on 32 bit windows
 - Use handles to module JSObject instead of object pointers

R=ahaas@chromium.org, bradnelson@chromium.org

Committed: https://crrev.com/8bd1e0dc889320609c179a3b20914f4fc632dae0
Cr-Commit-Position: refs/heads/master@{#37409}

[gdeepti, 2016-06-29 06:21:52]

Description was changed from

==========
Explicitly Disallow heap allocation when wasm memory references are updated
 - Enable grow memory tests on 32 bit windows
 - Use handles to module JSObject instead of object pointers

R=ahaas@chromium.org, bradnelson@chromium.org
==========

to

==========
[wasm] Explicitly Disallow heap allocation when wasm memory references are
updated
 - Enable grow memory tests on 32 bit windows
 - Use handles to module JSObject instead of object pointers

R=ahaas@chromium.org, bradnelson@chromium.org
==========

[bradnelson, 2016-06-29 07:03:35]

lgtm

[ahaas, 2016-06-29 07:13:32]

https://codereview.chromium.org/2105013004/diff/1/src/runtime/runtime-wasm.cc
File src/runtime/runtime-wasm.cc (right):

https://codereview.chromium.org/2105013004/diff/1/src/runtime/runtime-wasm.cc...
src/runtime/runtime-wasm.cc:30: Code* code =
isolate->inner_pointer_to_code_cache()->GetCacheEntry(pc)->code;
Use also "the DisallowHeapAllocation no_allocation;" scope here for the lifetime
of code, deopt_data, and obj below. These are pointers into the heap, and we
have to make sure that they are valid as long as they exist, i.e. that the GC
does not move the targeted objects away. Since the scope should not be the whole
function, you can create a sub-scope with { and }.

[gdeepti, 2016-06-29 23:38:38]

https://codereview.chromium.org/2105013004/diff/1/src/runtime/runtime-wasm.cc
File src/runtime/runtime-wasm.cc (right):

https://codereview.chromium.org/2105013004/diff/1/src/runtime/runtime-wasm.cc...
src/runtime/runtime-wasm.cc:30: Code* code =
isolate->inner_pointer_to_code_cache()->GetCacheEntry(pc)->code;
On 2016/06/29 07:13:31, ahaas wrote:
> Use also "the DisallowHeapAllocation no_allocation;" scope here for the
lifetime
> of code, deopt_data, and obj below. These are pointers into the heap, and we
> have to make sure that they are valid as long as they exist, i.e. that the GC
> does not move the targeted objects away. Since the scope should not be the
whole
> function, you can create a sub-scope with { and }.

Thanks for clarifying that, used "DisallowHeapAllocation no_allocation;" for the
lifetime of code, deopt_data, and changed obj to a handle.

[gdeepti, 2016-06-29 23:38:49]

The CQ bit was checked by gdeepti@chromium.org

[gdeepti, 2016-06-29 23:38:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@chromium.org
Link to the patchset: https://codereview.chromium.org/2105013004/#ps60001
(title: "Fix tests")

[commit-bot: I haz the power, 2016-06-29 23:38:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 23:40:44]

Description was changed from

==========
[wasm] Explicitly Disallow heap allocation when wasm memory references are
updated
 - Enable grow memory tests on 32 bit windows
 - Use handles to module JSObject instead of object pointers

R=ahaas@chromium.org, bradnelson@chromium.org
==========

to

==========
[wasm] Explicitly Disallow heap allocation when wasm memory references are
updated
 - Enable grow memory tests on 32 bit windows
 - Use handles to module JSObject instead of object pointers

R=ahaas@chromium.org, bradnelson@chromium.org
==========

[commit-bot: I haz the power, 2016-06-29 23:40:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-29 23:42:53]

Description was changed from

==========
[wasm] Explicitly Disallow heap allocation when wasm memory references are
updated
 - Enable grow memory tests on 32 bit windows
 - Use handles to module JSObject instead of object pointers

R=ahaas@chromium.org, bradnelson@chromium.org
==========

to

==========
[wasm] Explicitly Disallow heap allocation when wasm memory references are
updated
 - Enable grow memory tests on 32 bit windows
 - Use handles to module JSObject instead of object pointers

R=ahaas@chromium.org, bradnelson@chromium.org

Committed: https://crrev.com/8bd1e0dc889320609c179a3b20914f4fc632dae0
Cr-Commit-Position: refs/heads/master@{#37409}
==========

[commit-bot: I haz the power, 2016-06-29 23:42:57]

Patchset 4 (id:??) landed as
https://crrev.com/8bd1e0dc889320609c179a3b20914f4fc632dae0
Cr-Commit-Position: refs/heads/master@{#37409}