src/wasm/wasm-module.h - Issue 2105013004: Explicitly Disallow heap allocation when wasm memory references are updated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-module.h

Issue 2105013004: Explicitly Disallow heap allocation when wasm memory references are updated (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/wasm/wasm-module.h

diff --git a/src/wasm/wasm-module.h b/src/wasm/wasm-module.h

index 081e7c09e3aa3d35974f8689bc05111215a78ce6..9ccdb68d4a03148a24ed3964e94189250377b4cd 100644

--- a/src/wasm/wasm-module.h

+++ b/src/wasm/wasm-module.h

@@ -364,7 +364,7 @@ WasmDebugInfo* GetDebugInfo(JSObject* wasm);

bool IsWasmObject(Object* object);

// Update memory references of code objects associated with the module

-bool UpdateWasmModuleMemory(JSObject* object, Address old_start,

+bool UpdateWasmModuleMemory(Handle<JSObject> object, Address old_start,

Address new_start, uint32_t old_size,

uint32_t new_size);

« no previous file with comments | « src/runtime/runtime-wasm.cc ('k') | src/wasm/wasm-module.cc » ('j') | no next file with comments »