Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2104973004: Revert of [turbofan] Implicitly emit eager checkpoint at graph building. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-checkpoint-graph-builder-4
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Implicitly emit eager checkpoint at graph building. (patchset #13 id:260001 of https://codereview.chromium.org/2074703002/ ) Reason for revert: Causers flaky failures on the waterfall on Mac with the following error in the builtin QuickSort method: # # Fatal error in Zone # Allocation failed - process out of memory # Original issue's description: > [turbofan] Implicitly emit eager checkpoint at graph building. > > This makes preparation of eager checkpoints within the graph builder > implicit. Every sub-expression visitation is now guaranteed to emit > valid checkpoints in AstContext. > > R=jarin@chromium.org > BUG=v8:5021 > > Committed: https://crrev.com/74e328efee7995aeee6d568f9d14f9bbc1087100 > Cr-Commit-Position: refs/heads/master@{#37368} TBR=jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5021 Committed: https://crrev.com/45190a4fbfa5199f6ddf5ed9a7e2f50be865e0db Cr-Commit-Position: refs/heads/master@{#37372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -138 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 58 chunks +121 lines, -105 lines 0 comments Download
M src/compiler/checkpoint-elimination.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/checkpoint-elimination.cc View 1 chunk +2 lines, -27 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
Created Revert of [turbofan] Implicitly emit eager checkpoint at graph building.
4 years, 5 months ago (2016-06-29 09:18:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104973004/1
4 years, 5 months ago (2016-06-29 09:18:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 09:18:59 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/45190a4fbfa5199f6ddf5ed9a7e2f50be865e0db Cr-Commit-Position: refs/heads/master@{#37372}
4 years, 5 months ago (2016-06-29 09:20:31 UTC) #7
Michael Starzinger
4 years, 5 months ago (2016-06-29 11:47:32 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2107163002/ by mstarzinger@chromium.org.

The reason for reverting is: Can be cleanly relanded without any changes after a
fix to redundancy elimination. Kudos go to Benedikt.

Depends on: https://codereview.chromium.org/2112463002/.

Powered by Google App Engine
This is Rietveld 408576698