Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: src/compiler/checkpoint-elimination.cc

Issue 2104973004: Revert of [turbofan] Implicitly emit eager checkpoint at graph building. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_turbofan-checkpoint-graph-builder-4
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/checkpoint-elimination.h ('k') | src/full-codegen/full-codegen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/checkpoint-elimination.h" 5 #include "src/compiler/checkpoint-elimination.h"
6 6
7 #include "src/compiler/node-properties.h" 7 #include "src/compiler/node-properties.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
(...skipping 12 matching lines...) Expand all
23 while (effect->op()->HasProperty(Operator::kNoWrite) && 23 while (effect->op()->HasProperty(Operator::kNoWrite) &&
24 effect->op()->EffectInputCount() == 1) { 24 effect->op()->EffectInputCount() == 1) {
25 if (effect->opcode() == IrOpcode::kCheckpoint) return true; 25 if (effect->opcode() == IrOpcode::kCheckpoint) return true;
26 effect = NodeProperties::GetEffectInput(effect); 26 effect = NodeProperties::GetEffectInput(effect);
27 } 27 }
28 return false; 28 return false;
29 } 29 }
30 30
31 } // namespace 31 } // namespace
32 32
33 Reduction CheckpointElimination::ReduceCheckpoint(Node* node) { 33 Reduction CheckpointElimination::Reduce(Node* node) {
34 DCHECK_EQ(IrOpcode::kCheckpoint, node->opcode()); 34 if (node->opcode() != IrOpcode::kCheckpoint) return NoChange();
35 if (IsRedundantCheckpoint(node)) { 35 if (IsRedundantCheckpoint(node)) {
36 return Replace(NodeProperties::GetEffectInput(node)); 36 return Replace(NodeProperties::GetEffectInput(node));
37 } 37 }
38 return NoChange(); 38 return NoChange();
39 } 39 }
40
41 Reduction CheckpointElimination::ReduceReturn(Node* node) {
42 DCHECK_EQ(IrOpcode::kReturn, node->opcode());
43 Node* effect = NodeProperties::GetEffectInput(node);
44 if (effect->opcode() == IrOpcode::kCheckpoint && effect->OwnedBy(node)) {
45 // Any checkpoint that is wholly owned by a {Return} node can never be used
46 // for an actual bailout and can hence be cut out of the effect chain.
47 Node* replacement = NodeProperties::GetEffectInput(effect);
48 NodeProperties::ReplaceEffectInput(node, replacement);
49 return Changed(node);
50 }
51 return NoChange();
52 }
53
54 Reduction CheckpointElimination::Reduce(Node* node) {
55 switch (node->opcode()) {
56 case IrOpcode::kCheckpoint:
57 return ReduceCheckpoint(node);
58 case IrOpcode::kReturn:
59 return ReduceReturn(node);
60 default:
61 break;
62 }
63 return NoChange();
64 }
65 40
66 } // namespace compiler 41 } // namespace compiler
67 } // namespace internal 42 } // namespace internal
68 } // namespace v8 43 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/checkpoint-elimination.h ('k') | src/full-codegen/full-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698