Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 21049007: DevTools: Drop CSS Selector Profiler (Closed)

Created:
7 years, 4 months ago by apavlov
Modified:
7 years, 4 months ago
Reviewers:
vsevik, yurys, eseidel
CC:
blink-reviews, devtools-reviews_chromium.org, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, darktears, aandrey+blink_chromium.org, do-not-use
Visibility:
Public.

Description

DevTools: Drop CSS Selector Profiler It is of little use now, and its removal will help get rid of StyleRuleBase::m_sourceLine. R=eseidel@chromium.org BUG=265486 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155166

Patch Set 1 #

Patch Set 2 : Remove forgotten test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -710 lines) Patch
D LayoutTests/inspector/profiler/selector-profiler-url.html View 1 1 chunk +0 lines, -63 lines 0 comments Download
D LayoutTests/inspector/profiler/selector-profiler-url-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/css/ElementRuleCollector.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/css/ElementRuleCollector.cpp View 3 chunks +4 lines, -14 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 6 chunks +4 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 3 chunks +0 lines, -11 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 6 chunks +0 lines, -173 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/devtools/devtools.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D Source/devtools/front_end/CSSSelectorProfileView.js View 1 chunk +0 lines, -395 lines 0 comments Download
M Source/devtools/front_end/ProfilesPanel.js View 3 chunks +0 lines, -17 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/devtools/scripts/compile_frontend.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
apavlov
7 years, 4 months ago (2013-07-29 15:47:49 UTC) #1
eseidel
lgtm
7 years, 4 months ago (2013-07-29 18:09:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/21049007/1
7 years, 4 months ago (2013-07-29 18:09:40 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=368
7 years, 4 months ago (2013-07-29 21:12:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/21049007/1
7 years, 4 months ago (2013-07-30 10:50:20 UTC) #5
commit-bot: I haz the power
Failed to trigger a try job on linux_blink_rel HTTP Error 400: Bad Request
7 years, 4 months ago (2013-07-30 11:34:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/21049007/23001
7 years, 4 months ago (2013-07-30 11:34:27 UTC) #7
apavlov
7 years, 4 months ago (2013-07-30 14:38:38 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 manually as r155166 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698