src/ia32/lithium-codegen-ia32.cc - Issue 21049003: Smi-support for HSar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 21049003: Smi-support for HSar. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index 4ce7fd6067d106d92209b07a5f17d272bd15b292..b1300bcfb0cb18f911c99230bc330043ce929058 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -1750,6 +1750,9 @@ void LCodeGen::DoShiftI(LShiftI* instr) {

case Token::SAR:

if (shift_count != 0) {

__ sar(ToRegister(left), shift_count);

+ if (instr->hydrogen_value()->representation().IsSmi()) {

+ __ and_(ToRegister(left), -2);

mvstanton 2013/07/29 11:30:34 Instead of -2 could you use ~kSmiTagMask?

+ }

}

break;

case Token::SHR: