src/arm/lithium-codegen-arm.cc - Issue 21049003: Smi-support for HSar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 21049003: Smi-support for HSar. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/lithium-codegen-arm.cc

diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc

index 057ca1ef2bae528deba94161f7478d26203a4d8c..376d4b3fff90fd38eab111c9143cba374bd6f885 100644

--- a/src/arm/lithium-codegen-arm.cc

+++ b/src/arm/lithium-codegen-arm.cc

@@ -1725,6 +1725,9 @@ void LCodeGen::DoShiftI(LShiftI* instr) {

case Token::SAR:

if (shift_count != 0) {

__ mov(result, Operand(left, ASR, shift_count));

+ if (instr->hydrogen_value()->representation().IsSmi()) {

+ __ and_(result, result, Operand(-2));

mvstanton 2013/07/29 11:30:34 Same comment here as in ia32, use ~kSmiTagMask.

+ }

} else {

__ Move(result, left);

}