Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2104893005: UseCounter: Count usage of textarea[maxlength] and textarea[minlength] (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
Ilya Sherman, kochi
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

UseCounter: Count usage of textarea[maxlength] and textarea[minlength]. This is a preparation for a possible specification change. https://github.com/whatwg/html/issues/1467 BUG=624361 TBR=isherman@chromium.org Committed: https://crrev.com/53cf4f2c9884188d7625b2387fdc45c5aec61e5d Cr-Commit-Position: refs/heads/master@{#402806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (6 generated)
tkent
Would you review this please? kochi@ for third_party/WebKit/ isherman@ for histograms.xml.
4 years, 5 months ago (2016-06-29 07:42:23 UTC) #4
kochi
lgtm
4 years, 5 months ago (2016-06-29 07:57:06 UTC) #5
kochi
Maybe it's better to have a tracking crbug entry which corresponds to https://github.com/whatwg/html/issues/1467, to track ...
4 years, 5 months ago (2016-06-29 09:21:55 UTC) #6
tkent
On 2016/06/29 at 09:21:55, kochi wrote: > Maybe it's better to have a tracking crbug ...
4 years, 5 months ago (2016-06-29 11:41:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104893005/20001
4 years, 5 months ago (2016-06-29 11:41:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-06-29 14:54:33 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 14:54:56 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/53cf4f2c9884188d7625b2387fdc45c5aec61e5d Cr-Commit-Position: refs/heads/master@{#402806}
4 years, 5 months ago (2016-06-29 14:56:06 UTC) #14
Ilya Sherman
4 years, 5 months ago (2016-06-29 20:31:00 UTC) #15
Message was sent while issue was closed.
histograms.xml lgtm

Powered by Google App Engine
This is Rietveld 408576698