|
|
Chromium Code Reviews|
Created:
4 years, 5 months ago by kochi Modified:
4 years, 5 months ago CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, tkent Base URL:
https://chromium.googlesource.com/chromium/src.git@tkent Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCount usage of webkitRequestFullscreen in shadow
This counts webkitRequestFullscreen API usage in a shadow tree,
to see how popular requesting fullscreen of an element
in a shadow tree.
Overall usage is already counted as
"PrefixedRequestFullscreen" and "PrefixedRequestFullScreen".
BUG=535164
Committed: https://crrev.com/ab8c38147b4e094e70f1b627a46111ee5135db62
Cr-Commit-Position: refs/heads/master@{#403105}
Patch Set 1 : . #Patch Set 2 : rebase, fix compilation #
Messages
Total messages: 28 (13 generated)
Description was changed from ========== Count usage of webkitRequestFullscreen in shadow This counts webkitRequestFullscreen API usage in shadow tree. BUG=535164 ========== to ========== Count usage of webkitRequestFullscreen in shadow This counts webkitRequestFullscreen API usage in shadow tree. BUG=535164 ==========
kochi@chromium.org changed reviewers: + hayato@chromium.org, isherman@chromium.org
Patchset #1 (id:1) has been deleted
PTAL hayato-san, could you review this? isherman@, could you review for histograms.xml? Note: At this point, unprefixed API is test-only and not counted at all even without shadow.
Could you explain briefly why we want to count only for a shadow tree?
Description was changed from ========== Count usage of webkitRequestFullscreen in shadow This counts webkitRequestFullscreen API usage in shadow tree. BUG=535164 ========== to ========== Count usage of webkitRequestFullscreen in shadow This counts webkitRequestFullscreen API usage in a shadow tree, to see how popular requesting fullscreen of an element in a shadow tree. Overall usage is already counted as "PrefixedRequestFullscreen" and "PrefixedRequestFullScreen". BUG=535164 ==========
Added description.
On 2016/06/29 11:06:23, kochi wrote: > Added description. FYI I did the similar thing for Element.requestPointerLock() https://chromium.googlesource.com/chromium/src.git/+/d148a25d4b552d08fe0971fa... (ElementRequestPointerLockInShadow)
histograms.xml lgtm
tkent@chromium.org changed reviewers: + tkent@chromium.org
lgtm
The CQ bit was checked by kochi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by kochi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org, isherman@chromium.org Link to the patchset: https://codereview.chromium.org/2109113002/#ps40001 (title: "rebase, fix compilation")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
lgtm
The CQ bit was checked by kochi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Count usage of webkitRequestFullscreen in shadow This counts webkitRequestFullscreen API usage in a shadow tree, to see how popular requesting fullscreen of an element in a shadow tree. Overall usage is already counted as "PrefixedRequestFullscreen" and "PrefixedRequestFullScreen". BUG=535164 ========== to ========== Count usage of webkitRequestFullscreen in shadow This counts webkitRequestFullscreen API usage in a shadow tree, to see how popular requesting fullscreen of an element in a shadow tree. Overall usage is already counted as "PrefixedRequestFullscreen" and "PrefixedRequestFullScreen". BUG=535164 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Count usage of webkitRequestFullscreen in shadow This counts webkitRequestFullscreen API usage in a shadow tree, to see how popular requesting fullscreen of an element in a shadow tree. Overall usage is already counted as "PrefixedRequestFullscreen" and "PrefixedRequestFullScreen". BUG=535164 ========== to ========== Count usage of webkitRequestFullscreen in shadow This counts webkitRequestFullscreen API usage in a shadow tree, to see how popular requesting fullscreen of an element in a shadow tree. Overall usage is already counted as "PrefixedRequestFullscreen" and "PrefixedRequestFullScreen". BUG=535164 Committed: https://crrev.com/ab8c38147b4e094e70f1b627a46111ee5135db62 Cr-Commit-Position: refs/heads/master@{#403105} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ab8c38147b4e094e70f1b627a46111ee5135db62 Cr-Commit-Position: refs/heads/master@{#403105} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
