Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2109113002: Count usage of webkitRequestFullscreen in shadow (Closed)

Created:
4 years, 5 months ago by kochi
Modified:
4 years, 5 months ago
Reviewers:
tkent, hayato, Ilya Sherman
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, tkent
Base URL:
https://chromium.googlesource.com/chromium/src.git@tkent
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Count usage of webkitRequestFullscreen in shadow This counts webkitRequestFullscreen API usage in a shadow tree, to see how popular requesting fullscreen of an element in a shadow tree. Overall usage is already counted as "PrefixedRequestFullscreen" and "PrefixedRequestFullScreen". BUG=535164 Committed: https://crrev.com/ab8c38147b4e094e70f1b627a46111ee5135db62 Cr-Commit-Position: refs/heads/master@{#403105}

Patch Set 1 : . #

Patch Set 2 : rebase, fix compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/ElementFullscreen.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 28 (13 generated)
kochi
PTAL hayato-san, could you review this? isherman@, could you review for histograms.xml? Note: At this ...
4 years, 5 months ago (2016-06-29 10:51:56 UTC) #4
hayato
Could you explain briefly why we want to count only for a shadow tree?
4 years, 5 months ago (2016-06-29 11:02:24 UTC) #5
kochi
Added description.
4 years, 5 months ago (2016-06-29 11:06:23 UTC) #7
kochi
On 2016/06/29 11:06:23, kochi wrote: > Added description. FYI I did the similar thing for ...
4 years, 5 months ago (2016-06-29 11:19:11 UTC) #8
Ilya Sherman
histograms.xml lgtm
4 years, 5 months ago (2016-06-29 20:32:30 UTC) #9
tkent
lgtm
4 years, 5 months ago (2016-06-29 22:55:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109113002/20001
4 years, 5 months ago (2016-06-30 01:57:07 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/29177) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-06-30 01:58:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109113002/40001
4 years, 5 months ago (2016-06-30 02:14:08 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/248215)
4 years, 5 months ago (2016-06-30 03:55:23 UTC) #20
hayato
lgtm
4 years, 5 months ago (2016-06-30 03:57:31 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109113002/40001
4 years, 5 months ago (2016-06-30 05:29:33 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-06-30 06:54:57 UTC) #25
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 06:55:01 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 06:57:56 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab8c38147b4e094e70f1b627a46111ee5135db62
Cr-Commit-Position: refs/heads/master@{#403105}

Powered by Google App Engine
This is Rietveld 408576698