Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: src/log.cc

Issue 2104763002: Fix MSAN error on arm64 bot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove ifdef around MSAN macro Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/frames.cc ('k') | src/profiler/tick-sample.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index 43c3981bcabaa61309b71accc2c80d3880fe05a9..3e7677edf1955400cae41889f69e06544b8e7301 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -647,8 +647,9 @@ class Ticker: public sampler::Sampler {
v8::Isolate* v8_isolate = isolate();
Isolate* isolate = reinterpret_cast<Isolate*>(v8_isolate);
#if defined(USE_SIMULATOR)
- SimulatorHelper::FillRegisters(isolate,
- const_cast<v8::RegisterState*>(&state));
+ if (!SimulatorHelper::FillRegisters(isolate,
+ const_cast<v8::RegisterState*>(&state)))
+ return;
#endif
TickSample* sample = isolate->cpu_profiler()->StartTickSample();
TickSample sample_obj;
« no previous file with comments | « src/frames.cc ('k') | src/profiler/tick-sample.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698