Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Issue 2104663003: Prepare ChromeVox for webstore release. (Closed)

Created:
4 years, 5 months ago by David Tseng
Modified:
4 years, 5 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare ChromeVox for webstore release. - stub out some api's not available to non-Chrome OS platforms and some api's not are not yet in stable - fix gn build for min content script used only for webstore - webstore now does not have any excluded scripts because it excludes all scripts including our min content script BUG=623091, 619113 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8ae6b9392ef0d2ac5eeb2cec1ae6a68d7ace056d Cr-Commit-Position: refs/heads/master@{#402882}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove new line #

Patch Set 3 : Stubs. #

Patch Set 4 : Fix Aura. #

Patch Set 5 : Fix manifest for webstore. #

Patch Set 6 : Fix key maps. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -63 lines) Patch
M chrome/browser/resources/chromeos/chromevox/BUILD.gn View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/externs.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/prefs.js View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js View 1 2 6 chunks +4 lines, -17 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 2 3 4 5 5 chunks +28 lines, -29 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 2 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js View 1 2 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/loader.js View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/notifications.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/cvox2/background/stubs.js View 1 2 3 4 1 chunk +37 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/tools/publish_webstore_extension.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
David Tseng
This appears to fix the issues we're seeing on Mac by avoiding the use of ...
4 years, 5 months ago (2016-06-27 22:47:32 UTC) #3
dmazzoni
lgtm https://codereview.chromium.org/2104663003/diff/1/chrome/browser/resources/chromeos/chromevox/chromevox/background/externs.js File chrome/browser/resources/chromeos/chromevox/chromevox/background/externs.js (right): https://codereview.chromium.org/2104663003/diff/1/chrome/browser/resources/chromeos/chromevox/chromevox/background/externs.js#newcode73 chrome/browser/resources/chromeos/chromevox/chromevox/background/externs.js:73: onAccessibilityGesture; nit: no newline needed
4 years, 5 months ago (2016-06-27 22:52:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104663003/40001
4 years, 5 months ago (2016-06-28 17:41:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/246829)
4 years, 5 months ago (2016-06-28 19:31:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104663003/40001
4 years, 5 months ago (2016-06-28 19:34:12 UTC) #13
David Tseng
FYI. Finished testing on both linux and mac. Added a few more api's we need ...
4 years, 5 months ago (2016-06-28 22:51:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104663003/100001
4 years, 5 months ago (2016-06-29 17:38:31 UTC) #21
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-06-29 18:57:09 UTC) #23
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 18:58:54 UTC) #25
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/8ae6b9392ef0d2ac5eeb2cec1ae6a68d7ace056d
Cr-Commit-Position: refs/heads/master@{#402882}

Powered by Google App Engine
This is Rietveld 408576698