chrome/browser/resources/chromeos/chromevox/cvox2/background/notifications.js - Issue 2104663003: Prepare ChromeVox for webstore release.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/notifications.js

Issue 2104663003: Prepare ChromeVox for webstore release. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix key maps. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/loader.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/notifications.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/notifications.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/notifications.js

index e07e88b7bf735b00a81b0c42172c5fef1f61c20d..a28109f97644661db0c56e2f32857958900781ff 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/notifications.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/notifications.js

@@ -24,7 +24,8 @@ UpdateNotification.prototype = {

/** @return {boolean} */

shouldShow: function() {

return !localStorage['notifications_update_notification_shown'] &&

- chrome.runtime.getManifest().version >= '53';

+ chrome.runtime.getManifest().version >= '53' &&

+ cvox.ChromeVox.isChromeOS;

/** Shows the notification. */