Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2104603002: Disable DisplayItemClient aliveness checking when DCHECK is off (Closed)

Created:
4 years, 5 months ago by Xianzhu
Modified:
4 years, 5 months ago
Reviewers:
chrishtr
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable DisplayItemClient aliveness checking when DCHECK is off Only 1 crash report on 53.0.2777.0, and no crash reports after. Disable the checking when DCHECK is off to unblock beta release of m53. BUG=609218 Committed: https://crrev.com/64a18013d7e52fe0372b97ac586e0ed652637bb0 Cr-Commit-Position: refs/heads/master@{#402372}

Patch Set 1 #

Patch Set 2 : Disable DisplayItemClient aliveness checking when DCHECK is off #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Xianzhu
4 years, 5 months ago (2016-06-27 21:01:57 UTC) #2
chrishtr
lgtm
4 years, 5 months ago (2016-06-27 21:21:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104603002/1
4 years, 5 months ago (2016-06-27 21:22:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/159388)
4 years, 5 months ago (2016-06-27 21:50:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104603002/20001
4 years, 5 months ago (2016-06-28 00:21:15 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 02:01:00 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 02:02:49 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/64a18013d7e52fe0372b97ac586e0ed652637bb0
Cr-Commit-Position: refs/heads/master@{#402372}

Powered by Google App Engine
This is Rietveld 408576698