Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2104603002: Disable DisplayItemClient aliveness checking when DCHECK is off (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable DisplayItemClient aliveness checking when DCHECK is off Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 2897 matching lines...) Expand 10 before | Expand all | Expand 10 after
2908 m_needsRepaint = false; 2908 m_needsRepaint = false;
2909 } 2909 }
2910 2910
2911 PaintTiming* PaintLayer::paintTiming() 2911 PaintTiming* PaintLayer::paintTiming()
2912 { 2912 {
2913 if (Node* node = layoutObject()->node()) 2913 if (Node* node = layoutObject()->node())
2914 return &PaintTiming::from(node->document()); 2914 return &PaintTiming::from(node->document());
2915 return nullptr; 2915 return nullptr;
2916 } 2916 }
2917 2917
2918 #if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS
2918 void PaintLayer::endShouldKeepAliveAllClientsRecursive() 2919 void PaintLayer::endShouldKeepAliveAllClientsRecursive()
2919 { 2920 {
2920 for (PaintLayer* child = firstChild(); child; child = child->nextSibling()) 2921 for (PaintLayer* child = firstChild(); child; child = child->nextSibling())
2921 child->endShouldKeepAliveAllClientsRecursive(); 2922 child->endShouldKeepAliveAllClientsRecursive();
2922 #if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS
2923 DisplayItemClient::endShouldKeepAliveAllClients(this); 2923 DisplayItemClient::endShouldKeepAliveAllClients(this);
2924 }
2924 #endif 2925 #endif
2925 }
2926 2926
2927 DisableCompositingQueryAsserts::DisableCompositingQueryAsserts() 2927 DisableCompositingQueryAsserts::DisableCompositingQueryAsserts()
2928 : m_disabler(gCompositingQueryMode, CompositingQueriesAreAllowed) { } 2928 : m_disabler(gCompositingQueryMode, CompositingQueriesAreAllowed) { }
2929 2929
2930 } // namespace blink 2930 } // namespace blink
2931 2931
2932 #ifndef NDEBUG 2932 #ifndef NDEBUG
2933 // FIXME: Rename? 2933 // FIXME: Rename?
2934 void showLayerTree(const blink::PaintLayer* layer) 2934 void showLayerTree(const blink::PaintLayer* layer)
2935 { 2935 {
(...skipping 10 matching lines...) Expand all
2946 2946
2947 void showLayerTree(const blink::LayoutObject* layoutObject) 2947 void showLayerTree(const blink::LayoutObject* layoutObject)
2948 { 2948 {
2949 if (!layoutObject) { 2949 if (!layoutObject) {
2950 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n"); 2950 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n");
2951 return; 2951 return;
2952 } 2952 }
2953 showLayerTree(layoutObject->enclosingLayer()); 2953 showLayerTree(layoutObject->enclosingLayer());
2954 } 2954 }
2955 #endif 2955 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698