Implement a test for DefaultComponentInstallerTest

Implement a test for DefaultComponentInstallerTest.

This test checks that component metadata such as "ap"
is propagated correctly from the installer to the component update service.

R=waffles
BUG=599703
Committed: https://crrev.com/6a57db902d9a85e49d769dc3476a9ac6caf67d01
Cr-Commit-Position: refs/heads/master@{#402314}

[Sorin Jianu, 2016-06-27 19:42:21]

Description was changed from

==========
.


.


Merge branch 'master' of https://chromium.googlesource.com/chromium/src into
component-attributes


wip

BUG=
==========

to

==========
Implement a test for DefaultComponentInstallerTest.

This test checks that component metadata such as "ap"
is propagated correctly from the installer to the component update service.

R=waffles
BUG=599703
==========

[Sorin Jianu, 2016-06-27 19:44:05]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 19:44:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[waffles, 2016-06-27 20:32:59]

waffles@chromium.org changed reviewers:
+ waffles@chromium.org

[waffles, 2016-06-27 20:33:00]

lgtm

https://codereview.chromium.org/2104513003/diff/1/components/component_update...
File components/component_updater/default_component_installer_unittest.cc
(right):

https://codereview.chromium.org/2104513003/diff/1/components/component_update...
components/component_updater/default_component_installer_unittest.cc:98:
std::string GetAp() const override { return std::string("fake-ap"); }
Why not just "fake-ap"?

[commit-bot: I haz the power, 2016-06-27 20:37:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 20:37:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sorin Jianu, 2016-06-27 20:51:36]

thank you!

https://codereview.chromium.org/2104513003/diff/1/components/component_update...
File components/component_updater/default_component_installer_unittest.cc
(right):

https://codereview.chromium.org/2104513003/diff/1/components/component_update...
components/component_updater/default_component_installer_unittest.cc:98:
std::string GetAp() const override { return std::string("fake-ap"); }
On 2016/06/27 20:32:59, waffles wrote:
> Why not just "fake-ap"?

Done.

[Sorin Jianu, 2016-06-27 20:51:42]

The CQ bit was checked by sorin@chromium.org

[Sorin Jianu, 2016-06-27 20:51:42]

The patchset sent to the CQ was uploaded after l-g-t-m from waffles@chromium.org
Link to the patchset: https://codereview.chromium.org/2104513003/#ps20001
(title: "feedback")

[commit-bot: I haz the power, 2016-06-27 20:52:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 22:28:33]

Description was changed from

==========
Implement a test for DefaultComponentInstallerTest.

This test checks that component metadata such as "ap"
is propagated correctly from the installer to the component update service.

R=waffles
BUG=599703
==========

to

==========
Implement a test for DefaultComponentInstallerTest.

This test checks that component metadata such as "ap"
is propagated correctly from the installer to the component update service.

R=waffles
BUG=599703
==========

[commit-bot: I haz the power, 2016-06-27 22:28:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-27 22:31:45]

Description was changed from

==========
Implement a test for DefaultComponentInstallerTest.

This test checks that component metadata such as "ap"
is propagated correctly from the installer to the component update service.

R=waffles
BUG=599703
==========

to

==========
Implement a test for DefaultComponentInstallerTest.

This test checks that component metadata such as "ap"
is propagated correctly from the installer to the component update service.

R=waffles
BUG=599703

Committed: https://crrev.com/6a57db902d9a85e49d769dc3476a9ac6caf67d01
Cr-Commit-Position: refs/heads/master@{#402314}
==========

[commit-bot: I haz the power, 2016-06-27 22:31:46]

Patchset 2 (id:??) landed as
https://crrev.com/6a57db902d9a85e49d769dc3476a9ac6caf67d01
Cr-Commit-Position: refs/heads/master@{#402314}