third_party: Update to version 8 of remote_shell_protocol

third_party: Update to version 8 of remote_shell_protocol

* Add remote-shell interface to control system modality
* Add shell-mode event to notify the shell mode switch
* Shadow underlay should be deleted when shadow is turned off

BUG=b/29625835, b/29229887
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b477262b8b9db47e5589304d26fb9338f64c2194
Cr-Commit-Position: refs/heads/master@{#403028}

[oshima, 2016-06-27 19:24:38]

Description was changed from

==========
[WIP]:

* Add remote-shell interface to control system modality
* Add shell-mode event to notify the shell mode switch

BUG=

patch from issue 2098363002 at patchset 1 (http://crrev.com/2098363002#ps1)
==========

to

==========
[WIP]: third_party: Update to version 6 of remote_shell_protocol


* Add remote-shell interface to control system modality
* Add shell-mode event to notify the shell mode switch

BUG=

patch from issue 2098363002 at patchset 1 (http://crrev.com/2098363002#ps1)
==========

[oshima, 2016-06-27 19:24:39]

oshima@chromium.org changed reviewers:
+ reveman@chromium.org

[oshima, 2016-06-27 19:25:55]

This is still WIP and am now looking into android side, but I want to get early
feedback on this.

I may add input area event change too.

https://codereview.chromium.org/2104473002/diff/1/components/exo/shell_surfac...
File components/exo/shell_surface.cc (right):

https://codereview.chromium.org/2104473002/diff/1/components/exo/shell_surfac...
components/exo/shell_surface.cc:528: if (container_ ==
ash::kShellWindowId_SystemModalContainer) {
IIRC, you said you may need to undo this change (change activation on other
windows). I can do it as a part of this change, so please let me know.

https://codereview.chromium.org/2104473002/diff/1/third_party/wayland-protoco...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2104473002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:438:
</request>
This could be just one request with enum/bool but it seems that we prefer two
methods?

[reveman, 2016-06-27 20:45:00]

looks good

https://codereview.chromium.org/2104473002/diff/1/components/exo/shell_surfac...
File components/exo/shell_surface.cc (right):

https://codereview.chromium.org/2104473002/diff/1/components/exo/shell_surfac...
components/exo/shell_surface.cc:528: if (container_ ==
ash::kShellWindowId_SystemModalContainer) {
On 2016/06/27 at 19:25:54, oshima wrote:
> IIRC, you said you may need to undo this change (change activation on other
windows). I can do it as a part of this change, so please let me know.

If it's possible to move this logic to SetSystemModal instead of here then
that'd be great. This logic only exists for arc++ so we don't have to worry
about breaking something else by moving it.

[oshima, 2016-06-29 14:44:27]

Patchset #5 (id:80001) has been deleted

[oshima, 2016-06-29 14:44:39]

Patchset #3 (id:40001) has been deleted

[oshima, 2016-06-29 14:44:55]

Patchset #3 (id:60001) has been deleted

[oshima, 2016-06-29 14:58:07]

Description was changed from

==========
[WIP]: third_party: Update to version 6 of remote_shell_protocol


* Add remote-shell interface to control system modality
* Add shell-mode event to notify the shell mode switch

BUG=

patch from issue 2098363002 at patchset 1 (http://crrev.com/2098363002#ps1)
==========

to

==========
third_party: Update to version 8 of remote_shell_protocol

* Add remote-shell interface to control system modality
* Add shell-mode event to notify the shell mode switch
* Shadow underlay should be deleted when shadow is turned off

BUG=b/29625835, b/29229887
==========

[oshima, 2016-06-29 15:00:25]

Patchset #3 (id:100001) has been deleted

[oshima, 2016-06-29 15:00:54]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[oshima, 2016-06-29 15:01:22]

rebased, updated to 8, and fixed shadow. ptal.

https://codereview.chromium.org/2104473002/diff/1/components/exo/shell_surfac...
File components/exo/shell_surface.cc (right):

https://codereview.chromium.org/2104473002/diff/1/components/exo/shell_surfac...
components/exo/shell_surface.cc:528: if (container_ ==
ash::kShellWindowId_SystemModalContainer) {
On 2016/06/27 20:45:00, reveman wrote:
> On 2016/06/27 at 19:25:54, oshima wrote:
> > IIRC, you said you may need to undo this change (change activation on other
> windows). I can do it as a part of this change, so please let me know.
> 
> If it's possible to move this logic to SetSystemModal instead of here then
> that'd be great. This logic only exists for arc++ so we don't have to worry
> about breaking something else by moving it.

There seems to be other windows that are opened in this layer, but shouldn't be
modal, so I want to keep this, at least for now. We can try removing after
branch and see if it causes any issues.

[commit-bot: I haz the power, 2016-06-29 15:01:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 15:52:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 15:52:33]

Dry run: This issue passed the CQ dry run.

[reveman, 2016-06-29 16:41:27]

https://codereview.chromium.org/2104473002/diff/120001/components/exo/shell_s...
File components/exo/shell_surface.cc (right):

https://codereview.chromium.org/2104473002/diff/120001/components/exo/shell_s...
components/exo/shell_surface.cc:1141: delete shadow_underlay_;
Can we use RemoveChild instead? What about shadow_overlay_?

https://codereview.chromium.org/2104473002/diff/120001/third_party/wayland-pr...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2104473002/diff/120001/third_party/wayland-pr...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:134:
<enum name="layout_mode">
Move to the top as other enums are kept at the top even if introduced by a newer
version.

https://codereview.chromium.org/2104473002/diff/120001/third_party/wayland-pr...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:138:
<entry name="windowed" value="1" summary="mulitple windows"/>
multiple windows

https://codereview.chromium.org/2104473002/diff/120001/third_party/wayland-pr...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:459:
<!-- Version 8 additions -->
nit: blank line after this

[oshima, 2016-06-29 21:46:59]

Description was changed from

==========
third_party: Update to version 8 of remote_shell_protocol

* Add remote-shell interface to control system modality
* Add shell-mode event to notify the shell mode switch
* Shadow underlay should be deleted when shadow is turned off

BUG=b/29625835, b/29229887
==========

to

==========
third_party: Update to version 8 of remote_shell_protocol

* Add remote-shell interface to control system modality
* Add shell-mode event to notify the shell mode switch
* Shadow underlay should be deleted when shadow is turned off

BUG=b/29625835, b/29229887
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[oshima, 2016-06-29 21:47:09]

https://codereview.chromium.org/2104473002/diff/120001/components/exo/shell_s...
File components/exo/shell_surface.cc (right):

https://codereview.chromium.org/2104473002/diff/120001/components/exo/shell_s...
components/exo/shell_surface.cc:1141: delete shadow_underlay_;
On 2016/06/29 16:41:27, reveman wrote:
> Can we use RemoveChild instead? What about shadow_overlay_?

Shadow overlay is invisible, so we don't have to delete/hide it.

I changed to just hide it instead because I want to keep the ownership straight.

https://codereview.chromium.org/2104473002/diff/120001/third_party/wayland-pr...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2104473002/diff/120001/third_party/wayland-pr...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:134:
<enum name="layout_mode">
On 2016/06/29 16:41:27, reveman wrote:
> Move to the top as other enums are kept at the top even if introduced by a
newer
> version.

Done.

https://codereview.chromium.org/2104473002/diff/120001/third_party/wayland-pr...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:138:
<entry name="windowed" value="1" summary="mulitple windows"/>
On 2016/06/29 16:41:27, reveman wrote:
> multiple windows 

Done.

https://codereview.chromium.org/2104473002/diff/120001/third_party/wayland-pr...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:459:
<!-- Version 8 additions -->
On 2016/06/29 16:41:27, reveman wrote:
> nit: blank line after this

Done.

[oshima, 2016-06-29 22:17:52]

Patchset #4 (id:140001) has been deleted

[oshima, 2016-06-29 22:34:39]

uploaded new patch. PTAL.

Sorry for uploading wrong one.

[reveman, 2016-06-29 22:46:33]

lgtm

https://codereview.chromium.org/2104473002/diff/160001/third_party/wayland-pr...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2104473002/diff/160001/third_party/wayland-pr...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:143:
<description summary="dlayout mode changed">
nit: s/dlayout/layout/

[oshima, 2016-06-29 23:43:32]

https://codereview.chromium.org/2104473002/diff/160001/third_party/wayland-pr...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2104473002/diff/160001/third_party/wayland-pr...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:143:
<description summary="dlayout mode changed">
On 2016/06/29 22:46:33, reveman wrote:
> nit: s/dlayout/layout/

Done.

[oshima, 2016-06-29 23:43:36]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-06-29 23:43:36]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2104473002/#ps180001
(title: "fixed typo")

[commit-bot: I haz the power, 2016-06-29 23:47:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 00:29:41]

Committed patchset #5 (id:180001)

[commit-bot: I haz the power, 2016-06-30 00:31:54]

Description was changed from

==========
third_party: Update to version 8 of remote_shell_protocol

* Add remote-shell interface to control system modality
* Add shell-mode event to notify the shell mode switch
* Shadow underlay should be deleted when shadow is turned off

BUG=b/29625835, b/29229887
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
third_party: Update to version 8 of remote_shell_protocol

* Add remote-shell interface to control system modality
* Add shell-mode event to notify the shell mode switch
* Shadow underlay should be deleted when shadow is turned off

BUG=b/29625835, b/29229887
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b477262b8b9db47e5589304d26fb9338f64c2194
Cr-Commit-Position: refs/heads/master@{#403028}
==========

[commit-bot: I haz the power, 2016-06-30 00:31:55]

Patchset 5 (id:??) landed as
https://crrev.com/b477262b8b9db47e5589304d26fb9338f64c2194
Cr-Commit-Position: refs/heads/master@{#403028}

[horo, 2016-06-30 01:47:47]

A revert of this CL (patchset #5 id:180001) has been created in
https://codereview.chromium.org/2110903003/ by horo@chromium.org.

The reason for reverting is: ShellSurfaceTest.ModalWindow failure in Linux
ChromiumOS GN (dbg).

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

(view as text)
ShellSurfaceTest.ModalWindow (run #1):
[ RUN      ] ShellSurfaceTest.ModalWindow
Xlib:  extension "RANDR" missing on display ":9".
../../components/exo/shell_surface_unittest.cc:420: Failure
Value of: ash::WmShell::Get()->IsSystemModalWindowOpen()
  Actual: false
Expected: true
[  FAILED  ] ShellSurfaceTest.ModalWindow (210 ms)

ShellSurfaceTest.ModalWindow (run #2):
[ RUN      ] ShellSurfaceTest.ModalWindow
Xlib:  extension "RANDR" missing on display ":9".
../../components/exo/shell_surface_unittest.cc:420: Failure
Value of: ash::WmShell::Get()->IsSystemModalWindowOpen()
  Actual: false
Expected: true
[  FAILED  ] ShellSurfaceTest.ModalWindow (326 ms)

ShellSurfaceTest.ModalWindow (run #3):
[ RUN      ] ShellSurfaceTest.ModalWindow
Xlib:  extension "RANDR" missing on display ":9".
../../components/exo/shell_surface_unittest.cc:420: Failure
Value of: ash::WmShell::Get()->IsSystemModalWindowOpen()
  Actual: false
Expected: true
[  FAILED  ] ShellSurfaceTest.ModalWindow (352 ms)

ShellSurfaceTest.ModalWindow (run #4):
[ RUN      ] ShellSurfaceTest.ModalWindow
Xlib:  extension "RANDR" missing on display ":9".
../../components/exo/shell_surface_unittest.cc:420: Failure
Value of: ash::WmShell::Get()->IsSystemModalWindowOpen()
  Actual: false
Expected: true
[  FAILED  ] ShellSurfaceTest.ModalWindow (349 ms).

[oshima, 2016-06-30 05:11:39]

Patchset #6 (id:190001) has been deleted