third_party: Update to version 8 of remote_shell_protocol

components/exo/shell_surface.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/exo/shell_surface.h"
 
 #include "ash/aura/wm_window_aura.h"
 #include "ash/common/shell_window_ids.h"
 #include "ash/common/wm/window_resizer.h"
 #include "ash/common/wm/window_state.h"
@@ skipping 359 matching lines @@
 
 void ShellSurface::SetTitle(const base::string16& title) {
   TRACE_EVENT1("exo", "ShellSurface::SetTitle", "title",
                base::UTF16ToUTF8(title));
 
   title_ = title;
   if (widget_)
     widget_->UpdateWindowTitle();
 }
 
+void ShellSurface::SetSystemModal(bool system_modal) {
+  // System modal container is used by clients to implement client side
+  // managed system modal dialogs using a single ShellSurface instance.
+  // Hit-test region will be non-empty when at least one dialog exists on
+  // the client side. Here we detect the transition between no client side
+  // dialog and at least one dialog so activatable state is properly
+  // updated.
+  if (container_ != ash::kShellWindowId_SystemModalContainer) {
+    LOG(ERROR)
+        << "Only a window in SystemModalContainer can change the modality";
+    return;
+  }
+  widget_->GetNativeWindow()->SetProperty(
+      aura::client::kModalKey,
+      system_modal ? ui::MODAL_TYPE_SYSTEM : ui::MODAL_TYPE_NONE);
+}
+
 // static
 void ShellSurface::SetApplicationId(aura::Window* window,
                                     std::string* application_id) {
   window->SetProperty(kApplicationIdKey, application_id);
 }
 
 // static
 const std::string ShellSurface::GetApplicationId(aura::Window* window) {
   std::string* string_ptr = window->GetProperty(kApplicationIdKey);
   return string_ptr ? *string_ptr : std::string();
@@ skipping 107 matching lines @@
 
     // Apply new top inset height.
     if (pending_top_inset_height_ != top_inset_height_) {
       widget_->GetNativeWindow()->SetProperty(aura::client::kTopViewInset,
                                               pending_top_inset_height_);
       top_inset_height_ = pending_top_inset_height_;
     }
 
     gfx::Point surface_origin = GetSurfaceOrigin();
 
-    // System modal container is used by clients to implement client side
-    // managed system modal dialogs using a single ShellSurface instance.
-    // Hit-test region will be non-empty when at least one dialog exists on
-    // the client side. Here we detect the transition between no client side
-    // dialog and at least one dialog so activatable state is properly
-    // updated.
+    // System modal container is used by clients to implement overlay
+    // windows using a single ShellSurface instance.  If hit-test
+    // region is empty, then it is non interactive window and won't be
+    // activated.
     if (container_ == ash::kShellWindowId_SystemModalContainer) {

[oshima, 2016/06/27 19:25:54]

IIRC, you said you may need to undo this change (change activation on other
windows). I can do it as a part of this change, so please let me know.

[reveman, 2016/06/27 20:45:00]

If it's possible to move this logic to SetSystemModal instead of here then
that'd be great. This logic only exists for arc++ so we don't have to worry
about breaking something else by moving it.

[oshima, 2016/06/29 15:01:22]

There seems to be other windows that are opened in this layer, but shouldn't be
modal, so I want to keep this, at least for now. We can try removing after
branch and see if it causes any issues.

       gfx::Rect hit_test_bounds =
           surface_->GetHitTestBounds() + surface_origin.OffsetFromOrigin();
 
       // Prevent window from being activated when hit test bounds are empty.
       bool activatable = activatable_ && !hit_test_bounds.IsEmpty();
       if (activatable != CanActivate()) {
         set_can_activate(activatable);
-        widget_->GetNativeWindow()->SetProperty(
-            aura::client::kModalKey,
-            activatable ? ui::MODAL_TYPE_SYSTEM : ui::MODAL_TYPE_NONE);
-
         // Activate or deactivate window if activation state changed.
         if (activatable)
           wm::ActivateWindow(widget_->GetNativeWindow());
         else if (widget_->IsActive())
           wm::DeactivateWindow(widget_->GetNativeWindow());
       }
     }
 
     // Update surface bounds.
     surface_->window()->SetBounds(
@@ skipping 620 matching lines @@
                                         &shadow_bounds);
       shadow_overlay_->SetBounds(shadow_bounds);
       shadow_underlay_->SetBounds(shadow_bounds);
       shadow->SetContentBounds(gfx::Rect(shadow_bounds.size()));
       wm::SetShadowType(window, wm::SHADOW_TYPE_RECTANGULAR);
     }
   }
 }
 
 }  // namespace exo