Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 210443004: Do not clear root frame buffer for android webview (Closed)

Created:
6 years, 9 months ago by boliu
Modified:
6 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, darin-cc_chromium.org, aelias_OOO_until_Jul13
Visibility:
Public.

Description

Do not clear root frame buffer for android webview Android webview does not own the surface that compositor is drawing into, and so should in general not clear it before draw. Fixes internal bug b/13134274 BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
boliu
PTAL. Thanks!
6 years, 9 months ago (2014-03-24 23:51:28 UTC) #1
piman
lgtm
6 years, 9 months ago (2014-03-25 00:09:22 UTC) #2
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 9 months ago (2014-03-25 00:11:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/210443004/1
6 years, 9 months ago (2014-03-25 00:11:55 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 03:40:35 UTC) #5
Message was sent while issue was closed.
Change committed as 259131

Powered by Google App Engine
This is Rietveld 408576698