Make device_status_check complain if there are no available devices.

Make device_status_check complain if there are no available devices.

BUG=

Committed: https://crrev.com/d854e64a1a04cc83101d350f744815205b259d28
Cr-Commit-Position: refs/heads/master@{#403309}

[bpastene, 2016-06-29 17:21:01]

bpastene@chromium.org changed reviewers:
+ jbudorick@chromium.org, rnephew@chromium.org

[jbudorick, 2016-06-29 17:36:57]

https://codereview.chromium.org/2104413002/diff/1/build/android/buildbot/bb_d...
File build/android/buildbot/bb_device_status_check.py (right):

https://codereview.chromium.org/2104413002/diff/1/build/android/buildbot/bb_d...
build/android/buildbot/bb_device_status_check.py:414: return 0 if live_devices
else exit_codes.INFRA
What's the motivation? I'm guessing that exiting w/ an INFRA exit code isn't
clear enough?

[jbudorick, 2016-06-29 17:37:41]

https://codereview.chromium.org/2104413002/diff/1/build/android/buildbot/bb_d...
File build/android/buildbot/bb_device_status_check.py (right):

https://codereview.chromium.org/2104413002/diff/1/build/android/buildbot/bb_d...
build/android/buildbot/bb_device_status_check.py:414: return 0 if live_devices
else exit_codes.INFRA
On 2016/06/29 17:36:57, jbudorick (EMEA til June 30) wrote:
> What's the motivation? I'm guessing that exiting w/ an INFRA exit code isn't
> clear enough?

also, if you're going to add this, add it to
https://codesearch.chromium.org/chromium/src/third_party/catapult/devil/devil...
as well

[bpastene, 2016-06-29 18:25:15]

https://codereview.chromium.org/2104413002/diff/1/build/android/buildbot/bb_d...
File build/android/buildbot/bb_device_status_check.py (right):

https://codereview.chromium.org/2104413002/diff/1/build/android/buildbot/bb_d...
build/android/buildbot/bb_device_status_check.py:414: return 0 if live_devices
else exit_codes.INFRA
On 2016/06/29 17:37:40, jbudorick (EMEA til June 30) wrote:
> On 2016/06/29 17:36:57, jbudorick (EMEA til June 30) wrote:
> > What's the motivation? I'm guessing that exiting w/ an INFRA exit code isn't
> > clear enough?

Because it's not obvious why this fails:
https://uberchromegw.corp.google.com/i/tryserver.chromium.perf/builders/andro...

> also, if you're going to add this, add it to
>
https://codesearch.chromium.org/chromium/src/third_party/catapult/devil/devil...
> as well

https://codereview.chromium.org/2103333005/

[jbudorick, 2016-06-29 18:46:23]

On 2016/06/29 18:25:15, bpastene wrote:
>
https://codereview.chromium.org/2104413002/diff/1/build/android/buildbot/bb_d...
> File build/android/buildbot/bb_device_status_check.py (right):
> 
>
https://codereview.chromium.org/2104413002/diff/1/build/android/buildbot/bb_d...
> build/android/buildbot/bb_device_status_check.py:414: return 0 if live_devices
> else exit_codes.INFRA
> On 2016/06/29 17:37:40, jbudorick (EMEA til June 30) wrote:
> > On 2016/06/29 17:36:57, jbudorick (EMEA til June 30) wrote:
> > > What's the motivation? I'm guessing that exiting w/ an INFRA exit code
isn't
> > > clear enough?
> 
> Because it's not obvious why this fails:
>
https://uberchromegw.corp.google.com/i/tryserver.chromium.perf/builders/andro...
> 
> > also, if you're going to add this, add it to
> >
>
https://codesearch.chromium.org/chromium/src/third_party/catapult/devil/devil...
> > as well
> 
> https://codereview.chromium.org/2103333005/

lgtm

[bpastene, 2016-06-30 21:04:31]

The CQ bit was checked by bpastene@chromium.org

[commit-bot: I haz the power, 2016-06-30 21:05:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 22:08:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-30 22:10:57]

Description was changed from

==========
Make device_status_check complain if there are no available devices.

BUG=
==========

to

==========
Make device_status_check complain if there are no available devices.

BUG=

Committed: https://crrev.com/d854e64a1a04cc83101d350f744815205b259d28
Cr-Commit-Position: refs/heads/master@{#403309}
==========

[commit-bot: I haz the power, 2016-06-30 22:10:58]

Patchset 1 (id:??) landed as
https://crrev.com/d854e64a1a04cc83101d350f744815205b259d28
Cr-Commit-Position: refs/heads/master@{#403309}