build/android/buildbot/bb_device_status_check.py - Issue 2104413002: Make device_status_check complain if there are no available devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/buildbot/bb_device_status_check.py

Issue 2104413002: Make device_status_check complain if there are no available devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/buildbot/bb_device_status_check.py

diff --git a/build/android/buildbot/bb_device_status_check.py b/build/android/buildbot/bb_device_status_check.py

index 05adaef84a0fa35715d629495733e1d1c83919cb..01f2c2e312d61a53ec51b374642b78269b2eeb72 100755

--- a/build/android/buildbot/bb_device_status_check.py

+++ b/build/android/buildbot/bb_device_status_check.py

@@ -409,6 +409,8 @@ def main():

and not _IsBlacklisted(status['serial'], blacklist))]

# If all devices failed, or if there are no devices, it's an infra error.

+ if not live_devices:

+ logging.error('No available devices.')

return 0 if live_devices else exit_codes.INFRA

jbudorick 2016/06/29 17:36:57 What's the motivation? I'm guessing that exiting w

jbudorick 2016/06/29 17:37:40 also, if you're going to add this, add it to https

bpastene 2016/06/29 18:25:15 Because it's not obvious why this fails: https://u

« no previous file with comments | « no previous file | no next file » | no next file with comments »