pepper: parse context creation attrib list on the plugin side

pepper: parse context creation attrib list on the plugin side

This is simpler because we don't need to parse and copy lists of attributes.
We now only parse them in the same process that creates them, avoiding potential security issues.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/de2733a7d9c32815d4195e067dd628399f5996fc
Committed: https://crrev.com/fe4e488f15f1b955f6067721a937e960c13649aa
Cr-Original-Commit-Position: refs/heads/master@{#404024}
Cr-Commit-Position: refs/heads/master@{#404557}

[piman, 2016-06-29 20:54:48]

Description was changed from

==========
pepper: parse context creation attrib list on the plugin side

This is simpler because we don't need to copy lists of attributes, and we parse
them in the same process that creates them, avoiding potential security issues.

BUG=None
==========

to

==========
pepper: parse context creation attrib list on the plugin side

This is simpler because we don't need to parse and copy lists of attributes.
We now only parse them in the same process that creates them, avoiding potential
security issues.

BUG=None
==========

[piman, 2016-06-29 20:55:26]

piman@chromium.org changed reviewers:
+ bbudge@chromium.org, dcheng@chromium.org

[piman, 2016-06-29 20:55:27]

bbudge: please review
dcheng: security for ppapi/proxy/ppapi_messages.h

[piman, 2016-06-29 20:56:11]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 20:57:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 21:17:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 21:17:52]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[piman, 2016-06-29 22:00:16]

Description was changed from

==========
pepper: parse context creation attrib list on the plugin side

This is simpler because we don't need to parse and copy lists of attributes.
We now only parse them in the same process that creates them, avoiding potential
security issues.

BUG=None
==========

to

==========
pepper: parse context creation attrib list on the plugin side

This is simpler because we don't need to parse and copy lists of attributes.
We now only parse them in the same process that creates them, avoiding potential
security issues.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-06-29 22:02:53]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 22:07:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 22:19:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 22:19:16]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[dcheng, 2016-06-29 22:25:37]

ipc lgtm, since this just looks like a code move

[piman, 2016-06-29 22:35:24]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 22:36:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 23:34:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 23:34:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bbudge, 2016-06-30 00:09:39]

lgtm

[piman, 2016-06-30 17:55:29]

I need some more extensive build fixes for gyp, so holding off on this for now.

[piman, 2016-07-01 02:15:54]

piman@chromium.org changed reviewers:
+ bradnelson@chromium.org, danakj@chromium.org

[piman, 2016-07-01 02:15:55]

Ok, so I had to write more gyp stuff to make ui/gfx/geometry and
ui/gfx/ipc/geometry compile for NaCl.
bradnelson: PTAL at gyp files (+OWNERS for components/nacl_nonsfi.gyp and
ppapi/native_client)
danakj: OWNERS for ui/gfx  (gyp changes only).

[piman, 2016-07-01 02:16:05]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-01 02:16:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 03:08:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 03:08:45]

Dry run: This issue passed the CQ dry run.

[bradn, 2016-07-01 05:23:09]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-07-01 05:23:10]

lgtm

[bradnelson, 2016-07-01 05:23:36]

lgtm

[danakj, 2016-07-01 20:35:40]

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/gfx_geometry.gypi
File ui/gfx/gfx_geometry.gypi (right):

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/gfx_geometry.gyp...
ui/gfx/gfx_geometry.gypi:1: # Copyright (c) 2013 The Chromium Authors. All
rights reserved.
no (c), 2016

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/gfx_nacl.gyp
File ui/gfx/gfx_nacl.gyp (right):

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/gfx_nacl.gyp#new...
ui/gfx/gfx_nacl.gyp:1: # Copyright (c) 2013 The Chromium Authors. All rights
reserved.
dittos

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/ipc/geometry/gfx...
File ui/gfx/ipc/geometry/gfx_ipc_geometry.gypi (right):

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/ipc/geometry/gfx...
ui/gfx/ipc/geometry/gfx_ipc_geometry.gypi:1: # Copyright 2014 The Chromium
Authors. All rights reserved.
2016

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/ipc/geometry/gfx...
ui/gfx/ipc/geometry/gfx_ipc_geometry.gypi:14: 'gfx_param_traits.h',
did you exclude gfx_param_traits_macros.h on purpose?

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/ipc/geometry/gfx...
File ui/gfx/ipc/geometry/gfx_ipc_geometry_nacl.gyp (right):

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/ipc/geometry/gfx...
ui/gfx/ipc/geometry/gfx_ipc_geometry_nacl.gyp:1: # Copyright 2014 The Chromium
Authors. All rights reserved.
2016

[piman, 2016-07-06 18:34:24]

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/gfx_geometry.gypi
File ui/gfx/gfx_geometry.gypi (right):

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/gfx_geometry.gyp...
ui/gfx/gfx_geometry.gypi:1: # Copyright (c) 2013 The Chromium Authors. All
rights reserved.
On 2016/07/01 20:35:40, danakj wrote:
> no (c), 2016

Done.

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/gfx_nacl.gyp
File ui/gfx/gfx_nacl.gyp (right):

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/gfx_nacl.gyp#new...
ui/gfx/gfx_nacl.gyp:1: # Copyright (c) 2013 The Chromium Authors. All rights
reserved.
On 2016/07/01 20:35:40, danakj wrote:
> dittos

Done.

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/ipc/geometry/gfx...
File ui/gfx/ipc/geometry/gfx_ipc_geometry.gypi (right):

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/ipc/geometry/gfx...
ui/gfx/ipc/geometry/gfx_ipc_geometry.gypi:1: # Copyright 2014 The Chromium
Authors. All rights reserved.
On 2016/07/01 20:35:40, danakj wrote:
> 2016

Done.

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/ipc/geometry/gfx...
ui/gfx/ipc/geometry/gfx_ipc_geometry.gypi:14: 'gfx_param_traits.h',
On 2016/07/01 20:35:40, danakj wrote:
> did you exclude gfx_param_traits_macros.h on purpose?

There is no such file in ui/gfx/ipc/geometry :)
(There is one in ui/gfx/ipc, and it's a bit confusing to have identically named
files in ui/gfx/ipc and ui/gfx/ipc/geometry, but I claim innocence here)

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/ipc/geometry/gfx...
File ui/gfx/ipc/geometry/gfx_ipc_geometry_nacl.gyp (right):

https://codereview.chromium.org/2104403003/diff/80001/ui/gfx/ipc/geometry/gfx...
ui/gfx/ipc/geometry/gfx_ipc_geometry_nacl.gyp:1: # Copyright 2014 The Chromium
Authors. All rights reserved.
On 2016/07/01 20:35:40, danakj wrote:
> 2016

Done.

[piman, 2016-07-06 18:34:31]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 18:35:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-07-06 18:35:21]

LGTM

[piman, 2016-07-06 18:39:10]

The CQ bit was unchecked by piman@chromium.org

[piman, 2016-07-06 18:39:12]

The CQ bit was checked by piman@chromium.org

[piman, 2016-07-06 18:39:13]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org,
bbudge@chromium.org, bradnelson@chromium.org, bradnelson@google.com
Link to the patchset: https://codereview.chromium.org/2104403003/#ps120001
(title: "rebase")

[piman, 2016-07-06 18:39:22]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-07-06 18:39:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 19:47:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 19:47:32]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[piman, 2016-07-06 21:29:03]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-07-06 21:29:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 00:44:04]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-07-07 00:44:07]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 00:46:30]

Description was changed from

==========
pepper: parse context creation attrib list on the plugin side

This is simpler because we don't need to parse and copy lists of attributes.
We now only parse them in the same process that creates them, avoiding potential
security issues.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
pepper: parse context creation attrib list on the plugin side

This is simpler because we don't need to parse and copy lists of attributes.
We now only parse them in the same process that creates them, avoiding potential
security issues.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/de2733a7d9c32815d4195e067dd628399f5996fc
Cr-Commit-Position: refs/heads/master@{#404024}
==========

[commit-bot: I haz the power, 2016-07-07 00:46:32]

Patchset 7 (id:??) landed as
https://crrev.com/de2733a7d9c32815d4195e067dd628399f5996fc
Cr-Commit-Position: refs/heads/master@{#404024}

[brucedawson, 2016-07-07 01:47:54]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2129803002/ by brucedawson@chromium.org.

The reason for reverting is: Build errors including x86/x64 mismatches:

https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/bui....

[piman, 2016-07-07 21:57:45]

Description was changed from

==========
pepper: parse context creation attrib list on the plugin side

This is simpler because we don't need to parse and copy lists of attributes.
We now only parse them in the same process that creates them, avoiding potential
security issues.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/de2733a7d9c32815d4195e067dd628399f5996fc
Cr-Commit-Position: refs/heads/master@{#404024}
==========

to

==========
pepper: parse context creation attrib list on the plugin side

This is simpler because we don't need to parse and copy lists of attributes.
We now only parse them in the same process that creates them, avoiding potential
security issues.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/de2733a7d9c32815d4195e067dd628399f5996fc
Cr-Commit-Position: refs/heads/master@{#404024}
==========

[piman, 2016-07-08 02:40:45]

Patchset #12 (id:220001) has been deleted

[piman, 2016-07-08 02:40:50]

Patchset #11 (id:200001) has been deleted

[piman, 2016-07-08 02:40:55]

Patchset #10 (id:180001) has been deleted

[piman, 2016-07-08 02:41:02]

Patchset #9 (id:160001) has been deleted

[piman, 2016-07-08 03:23:05]

Patchset #9 (id:240001) has been deleted

[piman, 2016-07-08 04:10:14]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 04:10:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-07-08 04:16:23]

danakj: ptal, PS7 is the original patch that was reverted, PS8 is the same thing
rebased, and PS9 has the fixes (passed compile on win8_chromium_gyp_dbg, which I
believe is the same config as the original failure that led to the revert).

[commit-bot: I haz the power, 2016-07-08 06:12:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 06:12:31]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)

[danakj, 2016-07-08 21:30:55]

LGTM please delete gyp.

[piman, 2016-07-08 21:44:13]

The CQ bit was checked by piman@chromium.org

[piman, 2016-07-08 21:44:14]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
bradnelson@chromium.org, bradnelson@google.com, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2104403003/#ps260001
(title: "Fix win64 gyp")

[commit-bot: I haz the power, 2016-07-08 21:44:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 21:52:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 21:52:56]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[piman, 2016-07-08 23:11:40]

The CQ bit was checked by piman@chromium.org

[piman, 2016-07-08 23:11:41]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
bbudge@chromium.org, bradnelson@chromium.org, bradnelson@google.com,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2104403003/#ps280001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-08 23:12:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 01:18:34]

Description was changed from

==========
pepper: parse context creation attrib list on the plugin side

This is simpler because we don't need to parse and copy lists of attributes.
We now only parse them in the same process that creates them, avoiding potential
security issues.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/de2733a7d9c32815d4195e067dd628399f5996fc
Cr-Commit-Position: refs/heads/master@{#404024}
==========

to

==========
pepper: parse context creation attrib list on the plugin side

This is simpler because we don't need to parse and copy lists of attributes.
We now only parse them in the same process that creates them, avoiding potential
security issues.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/de2733a7d9c32815d4195e067dd628399f5996fc
Cr-Commit-Position: refs/heads/master@{#404024}
==========

[commit-bot: I haz the power, 2016-07-09 01:18:36]

Committed patchset #10 (id:280001)

[commit-bot: I haz the power, 2016-07-09 01:20:59]

Description was changed from

==========
pepper: parse context creation attrib list on the plugin side

This is simpler because we don't need to parse and copy lists of attributes.
We now only parse them in the same process that creates them, avoiding potential
security issues.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/de2733a7d9c32815d4195e067dd628399f5996fc
Cr-Commit-Position: refs/heads/master@{#404024}
==========

to

==========
pepper: parse context creation attrib list on the plugin side

This is simpler because we don't need to parse and copy lists of attributes.
We now only parse them in the same process that creates them, avoiding potential
security issues.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/de2733a7d9c32815d4195e067dd628399f5996fc
Committed: https://crrev.com/fe4e488f15f1b955f6067721a937e960c13649aa
Cr-Original-Commit-Position: refs/heads/master@{#404024}
Cr-Commit-Position: refs/heads/master@{#404557}
==========

[commit-bot: I haz the power, 2016-07-09 01:21:01]

Patchset 10 (id:??) landed as
https://crrev.com/fe4e488f15f1b955f6067721a937e960c13649aa
Cr-Commit-Position: refs/heads/master@{#404557}