Simplify ppapi Graphics3D size propagation a bit

Simplify ppapi Graphics3D size propagation a bit

- after https://codereview.chromium.org/2104403003/ we parse the attributes from
  the plugin side, so we know the correct size from the start, and we don't need
  to track the original size.
- we can also pass gfx::Size through IPC with some extra validation (negative
  coordinates) in common code.
- overall net fewer lines

BUG=None

Committed: https://crrev.com/1135d428cd8f5b19d458c5e67ba90776c4e09381
Committed: https://crrev.com/b36392c2dc38c81c6165a591e217e37598605137
Cr-Original-Commit-Position: refs/heads/master@{#404580}
Cr-Commit-Position: refs/heads/master@{#404893}

[piman, 2016-07-09 01:07:48]

piman@chromium.org changed reviewers:
+ bbudge@chromium.org, danakj@chromium.org, dcheng@chromium.org,
erikchen@chromium.org

[piman, 2016-07-09 01:07:49]

erikchen: please review (this is relative to your recent changes)
bbudge: ppapi OWNER
dcheng: ppapi/proxy/ppapi_messages.h security OWNER
danakj: ui/gfx/geometry OWNER (new dep)

[danakj, 2016-07-09 01:08:21]

DEPS LGTM

[erikchen, 2016-07-09 01:14:55]

lgtm

https://codereview.chromium.org/2136743002/diff/1/ppapi/shared_impl/DEPS
File ppapi/shared_impl/DEPS (right):

https://codereview.chromium.org/2136743002/diff/1/ppapi/shared_impl/DEPS#newc...
ppapi/shared_impl/DEPS:7: "+ui/gfx/geometry",
When I was working on my change, I had plumbed gfx::Size everywhere, and when I
was finished realized it would require a DEPS change, so I abandoned the
changes. :O

[piman, 2016-07-09 01:19:35]

https://codereview.chromium.org/2136743002/diff/1/ppapi/shared_impl/DEPS
File ppapi/shared_impl/DEPS (right):

https://codereview.chromium.org/2136743002/diff/1/ppapi/shared_impl/DEPS#newc...
ppapi/shared_impl/DEPS:7: "+ui/gfx/geometry",
On 2016/07/09 01:14:55, erikchen wrote:
> When I was working on my change, I had plumbed gfx::Size everywhere, and when
I
> was finished realized it would require a DEPS change, so I abandoned the
> changes. :O

Truth is, even after the DEPS thing, you'd certainly have run into the nacl+gyp
madness that would have made you run away screaming - see
https://codereview.chromium.org/2104403003/ - so don't feel bad :)

[bbudge, 2016-07-09 01:20:20]

LGTM w/nit
Thanks!

https://codereview.chromium.org/2136743002/diff/1/ppapi/proxy/ppb_graphics_3d...
File ppapi/proxy/ppb_graphics_3d_proxy.h (right):

https://codereview.chromium.org/2136743002/diff/1/ppapi/proxy/ppb_graphics_3d...
ppapi/proxy/ppb_graphics_3d_proxy.h:42: explicit Graphics3D(const HostResource&
resource, const gfx::Size& size);
nit: don't need explicit now.

[piman, 2016-07-09 01:26:45]

https://codereview.chromium.org/2136743002/diff/1/ppapi/proxy/ppb_graphics_3d...
File ppapi/proxy/ppb_graphics_3d_proxy.h (right):

https://codereview.chromium.org/2136743002/diff/1/ppapi/proxy/ppb_graphics_3d...
ppapi/proxy/ppb_graphics_3d_proxy.h:42: explicit Graphics3D(const HostResource&
resource, const gfx::Size& size);
On 2016/07/09 01:20:19, bbudge wrote:
> nit: don't need explicit now.

Done.

[piman, 2016-07-09 01:28:31]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-09 01:28:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-07-09 02:06:44]

rs lgtm for ipc changes

[commit-bot: I haz the power, 2016-07-09 04:37:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 04:37:27]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[piman, 2016-07-09 07:07:21]

The CQ bit was checked by piman@chromium.org

[piman, 2016-07-09 07:07:22]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
erikchen@chromium.org, bbudge@chromium.org
Link to the patchset: https://codereview.chromium.org/2136743002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-09 07:07:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 09:08:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 09:08:12]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[piman, 2016-07-10 04:23:06]

The CQ bit was checked by piman@chromium.org

[piman, 2016-07-10 04:23:07]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
erikchen@chromium.org, bbudge@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2136743002/#ps80001
(title: "typo")

[commit-bot: I haz the power, 2016-07-10 04:23:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-10 06:12:04]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-10 06:13:47]

Description was changed from

==========
Simplify ppapi Graphics3D size propagation a bit

- after https://codereview.chromium.org/2104403003/ we parse the attributes from
  the plugin side, so we know the correct size from the start, and we don't need
  to track the original size.
- we can also pass gfx::Size through IPC with some extra validation (negative
  coordinates) in common code.
- overall net fewer lines

BUG=None
==========

to

==========
Simplify ppapi Graphics3D size propagation a bit

- after https://codereview.chromium.org/2104403003/ we parse the attributes from
  the plugin side, so we know the correct size from the start, and we don't need
  to track the original size.
- we can also pass gfx::Size through IPC with some extra validation (negative
  coordinates) in common code.
- overall net fewer lines

BUG=None

Committed: https://crrev.com/1135d428cd8f5b19d458c5e67ba90776c4e09381
Cr-Commit-Position: refs/heads/master@{#404580}
==========

[commit-bot: I haz the power, 2016-07-10 06:13:48]

Patchset 5 (id:??) landed as
https://crrev.com/1135d428cd8f5b19d458c5e67ba90776c4e09381
Cr-Commit-Position: refs/heads/master@{#404580}

[Yuki, 2016-07-11 00:36:39]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2135063002/ by yukishiino@chromium.org.

The reason for reverting is: Build breakage on Win8 GYP.
https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/bui...

FAILED: nacl64.exe nacl64.exe.pdb 
E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests
environment.x64 True nacl64.exe "E:\b\depot_tools\python276_bin\python.exe
gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /OUT:nacl64.exe
@nacl64.exe.rsp" 1 mt.exe rc.exe
"obj\chrome\chrome_nacl_win64.nacl64.exe.intermediate.manifest"
obj\chrome\chrome_nacl_win64.nacl64.exe.generated.manifest
..\..\build\win\compatibility.manifest
ppapi_ipc_win64.lib(ppapi_ipc_win64.ppapi_messages.obj) : error LNK2019:
unresolved external symbol "__declspec(dllimport) public: __cdecl
gfx::Size::Size(void)" (__imp_??0Size@gfx@@QEAA@XZ) referenced in function
"public: __cdecl std::_Tuple_val<class gfx::Size>::_Tuple_val<class
gfx::Size>(void)" (??0?$_Tuple_val@VSize@gfx@@@std@@QEAA@XZ)

nacl64.exe : fatal error LNK1120: 1 unresolved externals
.

[piman, 2016-07-11 18:04:22]

Description was changed from

==========
Simplify ppapi Graphics3D size propagation a bit

- after https://codereview.chromium.org/2104403003/ we parse the attributes from
  the plugin side, so we know the correct size from the start, and we don't need
  to track the original size.
- we can also pass gfx::Size through IPC with some extra validation (negative
  coordinates) in common code.
- overall net fewer lines

BUG=None

Committed: https://crrev.com/1135d428cd8f5b19d458c5e67ba90776c4e09381
Cr-Commit-Position: refs/heads/master@{#404580}
==========

to

==========
Simplify ppapi Graphics3D size propagation a bit

- after https://codereview.chromium.org/2104403003/ we parse the attributes from
  the plugin side, so we know the correct size from the start, and we don't need
  to track the original size.
- we can also pass gfx::Size through IPC with some extra validation (negative
  coordinates) in common code.
- overall net fewer lines

BUG=None

Committed: https://crrev.com/1135d428cd8f5b19d458c5e67ba90776c4e09381
Cr-Commit-Position: refs/heads/master@{#404580}
==========

[piman, 2016-07-11 19:20:45]

Patchset #7 (id:120001) has been deleted

[piman, 2016-07-11 20:22:32]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 20:22:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-07-11 20:24:03]

bbudge: ptal at the couple of gyp fixes... PS5 is the original patch that was
landed and reverted, PS6 is the same patch rebased, PS7 has the fixes (checked
on the win8_chromium_gyp_dbg bot).

[bbudge, 2016-07-11 20:29:00]

Still LGTM

[piman, 2016-07-11 21:14:40]

The CQ bit was unchecked by piman@chromium.org

[piman, 2016-07-11 21:14:44]

The CQ bit was checked by piman@chromium.org

[piman, 2016-07-11 21:14:45]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
erikchen@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2136743002/#ps140001
(title: "fix win64+gyp build")

[commit-bot: I haz the power, 2016-07-11 21:15:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 00:54:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 00:54:41]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[piman, 2016-07-12 01:34:08]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-07-12 01:34:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 05:38:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 05:38:56]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[piman, 2016-07-12 14:30:46]

The CQ bit was unchecked by piman@chromium.org

[piman, 2016-07-12 14:30:46]

The CQ bit was checked by piman@chromium.org

[piman, 2016-07-12 14:30:47]

The CQ bit was checked by piman@chromium.org

[piman, 2016-07-12 14:30:47]

The CQ bit was unchecked by piman@chromium.org

[piman, 2016-07-12 14:30:49]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-07-12 14:32:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 18:05:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 18:05:20]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[piman, 2016-07-12 18:31:55]

The CQ bit was checked by piman@chromium.org

[piman, 2016-07-12 18:31:55]

The CQ bit was unchecked by piman@chromium.org

[piman, 2016-07-12 18:32:01]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-07-12 18:34:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 20:58:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 20:58:46]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[piman, 2016-07-12 21:04:42]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-07-12 21:06:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 22:38:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 22:38:42]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[piman, 2016-07-12 22:49:37]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-07-12 22:53:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 02:11:57]

Description was changed from

==========
Simplify ppapi Graphics3D size propagation a bit

- after https://codereview.chromium.org/2104403003/ we parse the attributes from
  the plugin side, so we know the correct size from the start, and we don't need
  to track the original size.
- we can also pass gfx::Size through IPC with some extra validation (negative
  coordinates) in common code.
- overall net fewer lines

BUG=None

Committed: https://crrev.com/1135d428cd8f5b19d458c5e67ba90776c4e09381
Cr-Commit-Position: refs/heads/master@{#404580}
==========

to

==========
Simplify ppapi Graphics3D size propagation a bit

- after https://codereview.chromium.org/2104403003/ we parse the attributes from
  the plugin side, so we know the correct size from the start, and we don't need
  to track the original size.
- we can also pass gfx::Size through IPC with some extra validation (negative
  coordinates) in common code.
- overall net fewer lines

BUG=None

Committed: https://crrev.com/1135d428cd8f5b19d458c5e67ba90776c4e09381
Cr-Commit-Position: refs/heads/master@{#404580}
==========

[commit-bot: I haz the power, 2016-07-13 02:11:59]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2016-07-13 02:15:00]

Description was changed from

==========
Simplify ppapi Graphics3D size propagation a bit

- after https://codereview.chromium.org/2104403003/ we parse the attributes from
  the plugin side, so we know the correct size from the start, and we don't need
  to track the original size.
- we can also pass gfx::Size through IPC with some extra validation (negative
  coordinates) in common code.
- overall net fewer lines

BUG=None

Committed: https://crrev.com/1135d428cd8f5b19d458c5e67ba90776c4e09381
Cr-Commit-Position: refs/heads/master@{#404580}
==========

to

==========
Simplify ppapi Graphics3D size propagation a bit

- after https://codereview.chromium.org/2104403003/ we parse the attributes from
  the plugin side, so we know the correct size from the start, and we don't need
  to track the original size.
- we can also pass gfx::Size through IPC with some extra validation (negative
  coordinates) in common code.
- overall net fewer lines

BUG=None

Committed: https://crrev.com/1135d428cd8f5b19d458c5e67ba90776c4e09381
Committed: https://crrev.com/b36392c2dc38c81c6165a591e217e37598605137
Cr-Original-Commit-Position: refs/heads/master@{#404580}
Cr-Commit-Position: refs/heads/master@{#404893}
==========

[commit-bot: I haz the power, 2016-07-13 02:15:01]

Patchset 7 (id:??) landed as
https://crrev.com/b36392c2dc38c81c6165a591e217e37598605137
Cr-Commit-Position: refs/heads/master@{#404893}