Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5694)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

Issue 2104393002: Adds UMA for PrerenderingOffliner request processing result status. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds note about interim offliner status codes and performs DCHECK that offliner does not return the… Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc b/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
index eef086b15126e5ab7b1c4fca8515074fb65088b6..f2a4b7853c6d3e1cf24083e720e94cb873d81ade 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
+++ b/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
@@ -56,9 +56,9 @@ class MockPrerenderingLoader : public PrerenderingLoader {
mock_loading_ = false;
mock_loaded_ = false;
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE,
- base::Bind(load_page_callback_, Offliner::RequestStatus::FAILED,
- nullptr /* web_contents */));
+ FROM_HERE, base::Bind(load_page_callback_,
+ Offliner::RequestStatus::PRERENDERING_FAILED,
+ nullptr /* web_contents */));
}
void CompleteLoadingAsLoaded() {
@@ -77,9 +77,9 @@ class MockPrerenderingLoader : public PrerenderingLoader {
mock_loading_ = false;
mock_loaded_ = false;
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE,
- base::Bind(load_page_callback_, Offliner::RequestStatus::CANCELED,
- nullptr /* web_contents */));
+ FROM_HERE, base::Bind(load_page_callback_,
+ Offliner::RequestStatus::PRERENDERING_CANCELED,
+ nullptr /* web_contents */));
}
void DisablePrerendering() { can_prerender_ = false; }
@@ -221,7 +221,7 @@ TEST_F(PrerenderingOfflinerTest, LoadAndSaveLoadStartedButFails) {
loader()->CompleteLoadingAsFailed();
PumpLoop();
EXPECT_TRUE(completion_callback_called());
- EXPECT_EQ(Offliner::RequestStatus::FAILED, request_status());
+ EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_FAILED, request_status());
EXPECT_TRUE(loader()->IsIdle());
EXPECT_FALSE(SaveInProgress());
}
@@ -280,7 +280,7 @@ TEST_F(PrerenderingOfflinerTest, LoadAndSaveLoadedButSaveFails) {
model()->CompleteSavingAsArchiveCreationFailed();
PumpLoop();
EXPECT_TRUE(completion_callback_called());
- EXPECT_EQ(Offliner::RequestStatus::FAILED_SAVE, request_status());
+ EXPECT_EQ(Offliner::RequestStatus::SAVE_FAILED, request_status());
EXPECT_FALSE(loader()->IsLoaded());
EXPECT_FALSE(SaveInProgress());
}
@@ -322,7 +322,7 @@ TEST_F(PrerenderingOfflinerTest, LoadAndSaveLoadedButThenCanceledFromLoader) {
loader()->CompleteLoadingAsCanceled();
PumpLoop();
EXPECT_TRUE(completion_callback_called());
- EXPECT_EQ(Offliner::RequestStatus::CANCELED, request_status());
+ EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_CANCELED, request_status());
EXPECT_FALSE(loader()->IsLoaded());
// Note: save still in progress since it does not support canceling.
EXPECT_TRUE(SaveInProgress());
« no previous file with comments | « chrome/browser/android/offline_pages/prerendering_offliner.cc ('k') | components/offline_pages/background/offliner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698