Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: chrome/browser/android/offline_pages/prerendering_offliner.cc

Issue 2104393002: Adds UMA for PrerenderingOffliner request processing result status. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds note about interim offliner status codes and performs DCHECK that offliner does not return the… Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/prerendering_offliner.h" 5 #include "chrome/browser/android/offline_pages/prerendering_offliner.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h" 8 #include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h"
9 #include "components/offline_pages/background/save_page_request.h" 9 #include "components/offline_pages/background/save_page_request.h"
10 #include "components/offline_pages/offline_page_model.h" 10 #include "components/offline_pages/offline_page_model.h"
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 pending_request_.reset(nullptr); 90 pending_request_.reset(nullptr);
91 GetOrCreateLoader()->StopLoading(); 91 GetOrCreateLoader()->StopLoading();
92 92
93 // Determine status and run the completion callback. 93 // Determine status and run the completion callback.
94 Offliner::RequestStatus save_status; 94 Offliner::RequestStatus save_status;
95 if (save_result == SavePageResult::SUCCESS) { 95 if (save_result == SavePageResult::SUCCESS) {
96 save_status = RequestStatus::SAVED; 96 save_status = RequestStatus::SAVED;
97 } else { 97 } else {
98 // TODO(dougarnett): Consider reflecting some recommendation to retry the 98 // TODO(dougarnett): Consider reflecting some recommendation to retry the
99 // request based on specific save error cases. 99 // request based on specific save error cases.
100 save_status = RequestStatus::FAILED_SAVE; 100 save_status = RequestStatus::SAVE_FAILED;
101 } 101 }
102 completion_callback.Run(request, save_status); 102 completion_callback.Run(request, save_status);
103 } 103 }
104 104
105 bool PrerenderingOffliner::LoadAndSave(const SavePageRequest& request, 105 bool PrerenderingOffliner::LoadAndSave(const SavePageRequest& request,
106 const CompletionCallback& callback) { 106 const CompletionCallback& callback) {
107 if (pending_request_) { 107 if (pending_request_) {
108 DVLOG(1) << "Already have pending request"; 108 DVLOG(1) << "Already have pending request";
109 return false; 109 return false;
110 } 110 }
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 } 157 }
158 158
159 PrerenderingLoader* PrerenderingOffliner::GetOrCreateLoader() { 159 PrerenderingLoader* PrerenderingOffliner::GetOrCreateLoader() {
160 if (!loader_) { 160 if (!loader_) {
161 loader_.reset(new PrerenderingLoader(browser_context_)); 161 loader_.reset(new PrerenderingLoader(browser_context_));
162 } 162 }
163 return loader_.get(); 163 return loader_.get();
164 } 164 }
165 165
166 } // namespace offline_pages 166 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698