chrome/browser/ui/gtk/omnibox/omnibox_view_gtk_unittest.cc - Issue 21042013: Have SearchProvider look up the omnibox start margin directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk_unittest.cc

Issue 21042013: Have SearchProvider look up the omnibox start margin directly. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Respond to comments. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/search_provider.cc ('K') | « chrome/browser/ui/gtk/location_bar_view_gtk.cc ('k') | chrome/browser/ui/omnibox/omnibox_controller.h » ('j') | chrome/browser/ui/search/instant_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk_unittest.cc

diff --git a/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk_unittest.cc b/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk_unittest.cc

index b3e429c1f8b3fd37d476bcd65685f8c1712afe3a..a77871a89077aa600d83fb11f2f72bd6fce86a4e 100644

--- a/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk_unittest.cc

+++ b/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk_unittest.cc

@@ -16,7 +16,6 @@

#include "testing/platform_test.h"

#include "ui/base/gtk/gtk_hig_constants.h"

#include "ui/gfx/image/image.h"

-#include "ui/gfx/rect.h"

namespace {

class OmniboxEditControllerMock : public OmniboxEditController {

@@ -34,7 +33,6 @@ class OmniboxEditControllerMock : public OmniboxEditController {

MOCK_CONST_METHOD0(GetTitle, string16());

MOCK_METHOD0(GetInstant, InstantController*());

MOCK_CONST_METHOD0(GetWebContents, content::WebContents*());

- MOCK_CONST_METHOD0(GetOmniboxBounds, gfx::Rect());

virtual ~OmniboxEditControllerMock() {}

};