chrome/browser/ui/gtk/location_bar_view_gtk.cc - Issue 21042013: Have SearchProvider look up the omnibox start margin directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/location_bar_view_gtk.cc

Issue 21042013: Have SearchProvider look up the omnibox start margin directly. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Respond to comments. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/search_provider.cc ('K') | « chrome/browser/ui/gtk/location_bar_view_gtk.h ('k') | chrome/browser/ui/gtk/omnibox/omnibox_view_gtk_unittest.cc » ('j') | chrome/browser/ui/search/instant_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/location_bar_view_gtk.cc

diff --git a/chrome/browser/ui/gtk/location_bar_view_gtk.cc b/chrome/browser/ui/gtk/location_bar_view_gtk.cc

index 8f8b8b0abb11f501cea599c54278e67b4251c6b2..b4849e470064986813da420fcd14503326711de2 100644

--- a/chrome/browser/ui/gtk/location_bar_view_gtk.cc

+++ b/chrome/browser/ui/gtk/location_bar_view_gtk.cc

@@ -92,7 +92,6 @@

#include "ui/gfx/font.h"

#include "ui/gfx/gtk_util.h"

#include "ui/gfx/image/image.h"

-#include "ui/gfx/rect.h"

using content::NavigationEntry;

using content::OpenURLParams;

@@ -618,12 +617,6 @@ WebContents* LocationBarViewGtk::GetWebContents() const {

return browser_->tab_strip_model()->GetActiveWebContents();

}

-gfx::Rect LocationBarViewGtk::GetOmniboxBounds() const {

- GtkAllocation hbox_allocation;

- gtk_widget_get_allocation(hbox_.get(), &hbox_allocation);

- return AllocationToRect(hbox_allocation);

void LocationBarViewGtk::SetPreviewEnabledPageAction(

ExtensionAction* page_action,

bool preview_enabled) {