Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 21042004: Make GlobalHandle::NodeBlock deletable (Closed)

Created:
7 years, 4 months ago by dcarney
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make GlobalHandle::NodeBlock deletable R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16040

Patch Set 1 #

Patch Set 2 : now with 10% better stats #

Patch Set 3 : added some tests #

Patch Set 4 : unified stats collection #

Patch Set 5 : added weak callbacks to test #

Total comments: 6

Patch Set 6 : fine, we'll do it your way #

Total comments: 4

Patch Set 7 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+644 lines, -208 lines) Patch
M src/global-handles.h View 1 2 3 4 5 6 3 chunks +57 lines, -7 lines 0 comments Download
M src/global-handles.cc View 1 2 3 4 5 6 10 chunks +380 lines, -149 lines 0 comments Download
M test/cctest/cctest.h View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
M test/cctest/test-global-handles.cc View 1 2 3 4 5 2 chunks +154 lines, -0 lines 0 comments Download
M test/cctest/test-strings.cc View 1 2 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dcarney
7 years, 4 months ago (2013-07-29 12:47:57 UTC) #1
Michael Starzinger
LGTM (with a few comments). This is a maintenance nightmare. https://codereview.chromium.org/21042004/diff/17001/src/global-handles.cc File src/global-handles.cc (right): https://codereview.chromium.org/21042004/diff/17001/src/global-handles.cc#newcode61 ...
7 years, 4 months ago (2013-08-01 12:29:01 UTC) #2
Sven Panne
As discussed offline with Michael: Wouldn't it be much easier and far more readable with: ...
7 years, 4 months ago (2013-08-01 12:44:49 UTC) #3
dcarney
please review this lastest round of awesome
7 years, 4 months ago (2013-08-02 11:12:36 UTC) #4
Michael Starzinger
Much better, a few more comments and nits. https://codereview.chromium.org/21042004/diff/25001/src/global-handles.cc File src/global-handles.cc (right): https://codereview.chromium.org/21042004/diff/25001/src/global-handles.cc#newcode316 src/global-handles.cc:316: : ...
7 years, 4 months ago (2013-08-02 11:59:51 UTC) #5
dcarney
7 years, 4 months ago (2013-08-05 07:34:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #7 manually as r16040 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698