Geolocation: Extract GeolocationProvider::Delegate into GeolocationDelegate (no new code)

Geolocation: Extract GeolocationProvider::Delegate into GeolocationDelegate (no new code)

This CL extracts GeolocationProvider::Delegate into
GeolocationDelegate, and adjust call/use sites. The
implementation is moved to content internals and to
a file on its own. No new code is added, this CL just
shoves code around.

Following up on https://codereview.chromium.org/2098553002/#msg33 :
> nit: I realize this is moving to device/. I would encourage you to make this to
> be a separate header (i.e. geolocation_delegate.) for two reasons:
> 1) it can be overridden and forward declared without including the this header
> 2) once you move this to device/geolocation, there's no more need for an
> interface/impl split of GeolocationProvider since it's out of content. so more
> stuff will move to this parent class.

BUG=612334
Committed: https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98
Cr-Commit-Position: refs/heads/master@{#402904}

[mcasas, 2016-06-28 22:24:59]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-06-28 22:25:07]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-06-28 22:39:31]

Description was changed from

==========
Geolocation: Extract GeolocationProvider::Delegate into GeolocationDelegate (no
new code)

This CL extracts GeolocationProvider::Delegate into a class on its own
GeolocationDelegate, and adjust call/use sites. The implementation is
moved to content internals and to a file on its own.


Following up on https://codereview.chromium.org/2098553002/#msg33 :
> nit: I realize this is moving to device/. I would encourage you to make this
to
> be a separate header (i.e. geolocation_delegate.) for two reasons:
> 1) it can be overridden and forward declared without including the this header
> 2) once you move this to device/geolocation, there's no more need for an
> interface/impl split of GeolocationProvider since it's out of content. so more
> stuff will move to this parent class.

BUG=612334
==========

to

==========
Geolocation: Extract GeolocationProvider::Delegate into GeolocationDelegate (no
new code)

This CL extracts GeolocationProvider::Delegate into 
GeolocationDelegate, and adjust call/use sites. The 
implementation is moved to content internals and to 
a file on its own. No new code is added, this CL just
shoves code around.

Following up on https://codereview.chromium.org/2098553002/#msg33 :
> nit: I realize this is moving to device/. I would encourage you to make this
to
> be a separate header (i.e. geolocation_delegate.) for two reasons:
> 1) it can be overridden and forward declared without including the this header
> 2) once you move this to device/geolocation, there's no more need for an
> interface/impl split of GeolocationProvider since it's out of content. so more
> stuff will move to this parent class.

BUG=612334
==========

[mcasas, 2016-06-28 23:39:44]

Patchset #1 (id:40001) has been deleted

[mcasas, 2016-06-28 23:41:29]

mcasas@chromium.org changed reviewers:
+ jam@chromium.org

[mcasas, 2016-06-28 23:41:30]

jam@ follow up  to this morning's CL

(mvanouwerkerk@, lethalantidote@ FYI).

[jam, 2016-06-29 17:08:08]

lgtm

https://codereview.chromium.org/2104193002/diff/80001/content/browser/geoloca...
File content/browser/geolocation/geolocation_delegate.cc (right):

https://codereview.chromium.org/2104193002/diff/80001/content/browser/geoloca...
content/browser/geolocation/geolocation_delegate.cc:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
nit: please put this in content/public/browser, like the other cc files for
interfaces there

[mcasas, 2016-06-29 19:03:08]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-06-29 19:03:08]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2104193002/#ps100001
(title: "jam@ nit: content/browser/geolocation/geolocation_delegate.cc -->
content/public/browser")

[commit-bot: I haz the power, 2016-06-29 19:04:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2016-06-29 19:04:45]

https://codereview.chromium.org/2104193002/diff/80001/content/browser/geoloca...
File content/browser/geolocation/geolocation_delegate.cc (right):

https://codereview.chromium.org/2104193002/diff/80001/content/browser/geoloca...
content/browser/geolocation/geolocation_delegate.cc:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
On 2016/06/29 17:08:08, jam wrote:
> nit: please put this in content/public/browser, like the other cc files for
> interfaces there

Done.

[commit-bot: I haz the power, 2016-06-29 19:44:23]

Description was changed from

==========
Geolocation: Extract GeolocationProvider::Delegate into GeolocationDelegate (no
new code)

This CL extracts GeolocationProvider::Delegate into 
GeolocationDelegate, and adjust call/use sites. The 
implementation is moved to content internals and to 
a file on its own. No new code is added, this CL just
shoves code around.

Following up on https://codereview.chromium.org/2098553002/#msg33 :
> nit: I realize this is moving to device/. I would encourage you to make this
to
> be a separate header (i.e. geolocation_delegate.) for two reasons:
> 1) it can be overridden and forward declared without including the this header
> 2) once you move this to device/geolocation, there's no more need for an
> interface/impl split of GeolocationProvider since it's out of content. so more
> stuff will move to this parent class.

BUG=612334
==========

to

==========
Geolocation: Extract GeolocationProvider::Delegate into GeolocationDelegate (no
new code)

This CL extracts GeolocationProvider::Delegate into 
GeolocationDelegate, and adjust call/use sites. The 
implementation is moved to content internals and to 
a file on its own. No new code is added, this CL just
shoves code around.

Following up on https://codereview.chromium.org/2098553002/#msg33 :
> nit: I realize this is moving to device/. I would encourage you to make this
to
> be a separate header (i.e. geolocation_delegate.) for two reasons:
> 1) it can be overridden and forward declared without including the this header
> 2) once you move this to device/geolocation, there's no more need for an
> interface/impl split of GeolocationProvider since it's out of content. so more
> stuff will move to this parent class.

BUG=612334
==========

[commit-bot: I haz the power, 2016-06-29 19:44:25]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-06-29 19:45:23]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-29 19:46:33]

Description was changed from

==========
Geolocation: Extract GeolocationProvider::Delegate into GeolocationDelegate (no
new code)

This CL extracts GeolocationProvider::Delegate into 
GeolocationDelegate, and adjust call/use sites. The 
implementation is moved to content internals and to 
a file on its own. No new code is added, this CL just
shoves code around.

Following up on https://codereview.chromium.org/2098553002/#msg33 :
> nit: I realize this is moving to device/. I would encourage you to make this
to
> be a separate header (i.e. geolocation_delegate.) for two reasons:
> 1) it can be overridden and forward declared without including the this header
> 2) once you move this to device/geolocation, there's no more need for an
> interface/impl split of GeolocationProvider since it's out of content. so more
> stuff will move to this parent class.

BUG=612334
==========

to

==========
Geolocation: Extract GeolocationProvider::Delegate into GeolocationDelegate (no
new code)

This CL extracts GeolocationProvider::Delegate into
GeolocationDelegate, and adjust call/use sites. The
implementation is moved to content internals and to
a file on its own. No new code is added, this CL just
shoves code around.

Following up on https://codereview.chromium.org/2098553002/#msg33 :
> nit: I realize this is moving to device/. I would encourage you to make this
to
> be a separate header (i.e. geolocation_delegate.) for two reasons:
> 1) it can be overridden and forward declared without including the this header
> 2) once you move this to device/geolocation, there's no more need for an
> interface/impl split of GeolocationProvider since it's out of content. so more
> stuff will move to this parent class.

BUG=612334

Committed: https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98
Cr-Commit-Position: refs/heads/master@{#402904}
==========

[commit-bot: I haz the power, 2016-06-29 19:46:35]

Patchset 3 (id:??) landed as
https://crrev.com/b05e977fa72205d2b7d8da7b8c82be063d02db98
Cr-Commit-Position: refs/heads/master@{#402904}