content/shell/browser/shell_content_browser_client.h - Issue 2104193002: Geolocation: Extract GeolocationProvider::Delegate into GeolocationDelegate (no new code)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_content_browser_client.h

Issue 2104193002: Geolocation: Extract GeolocationProvider::Delegate into GeolocationDelegate (no new code) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: jam@ nit: content/browser/geolocation/geolocation_delegate.cc --> content/public/browser Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/browser/shell_content_browser_client.h

diff --git a/content/shell/browser/shell_content_browser_client.h b/content/shell/browser/shell_content_browser_client.h

index e80feed6343cc5c86e4b3e25d3b3ef6314b10009..0a03b35ae90d2876031617b7dd04796bc2c8cf50 100644

--- a/content/shell/browser/shell_content_browser_client.h

+++ b/content/shell/browser/shell_content_browser_client.h

@@ -43,7 +43,7 @@ class ShellContentBrowserClient : public ContentBrowserClient {

void AppendExtraCommandLineSwitches(base::CommandLine* command_line,

int child_process_id) override;

void ResourceDispatcherHostCreated() override;

- GeolocationProvider::Delegate* CreateGeolocationDelegate() override;

+ GeolocationDelegate* CreateGeolocationDelegate() override;

std::string GetDefaultDownloadName() override;

WebContentsViewDelegate* GetWebContentsViewDelegate(

WebContents* web_contents) override;

« no previous file with comments | « content/public/browser/geolocation_provider.cc ('k') | content/shell/browser/shell_content_browser_client.cc » ('j') | no next file with comments »