Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2104143003: Build delegation for CQ jobs (Closed)

Created:
4 years, 5 months ago by Ziqi Xiong
Modified:
4 years, 5 months ago
Reviewers:
sullivan, RobertoCN, dtu
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

This CL allows test bots to delegate CQ build to faster builder bots instead of compiling locally. Similar to Issue 2061893003: Build delegation for perf tryjobs . BUG= http://crbug.com/601699 Committed: https://chromium.googlesource.com/chromium/tools/build/+/f20aae69a5e30a8b3425009b5000be11c8699b92

Patch Set 1 #

Patch Set 2 : Update step data for cq job #

Patch Set 3 : Rebase against master #

Patch Set 4 : Deprecate compile method #

Patch Set 5 : Rebase against master #

Patch Set 6 : Rebase against master #

Total comments: 2

Patch Set 7 : Remove compile method #

Total comments: 2

Patch Set 8 : Remove the remnant of compile method #

Patch Set 9 : Rebase against master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1962 lines, -1393 lines) Patch
M scripts/slave/recipe_modules/perf_try/api.py View 1 2 3 4 5 6 7 2 chunks +8 lines, -32 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.py View 1 2 3 4 5 6 7 8 1 chunk +38 lines, -12 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_fyi_perf_bisect.json View 1 2 3 4 5 6 7 8 4 chunks +81 lines, -56 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5X_perf_bisect.json View 1 2 3 4 5 6 7 8 4 chunks +81 lines, -56 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5_perf_bisect.json View 1 2 3 4 5 6 7 8 4 chunks +81 lines, -56 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus6_perf_bisect.json View 1 2 3 4 5 6 7 8 4 chunks +81 lines, -56 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus7_perf_bisect.json View 1 2 3 4 5 6 7 8 4 chunks +81 lines, -56 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus9_perf_bisect.json View 1 2 3 4 5 6 7 8 4 chunks +81 lines, -56 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_one_perf_bisect.json View 1 2 3 4 5 6 7 8 4 chunks +81 lines, -56 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_bisect.json View 1 2 3 4 5 6 7 8 4 chunks +81 lines, -56 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_cq.json View 1 2 3 4 5 6 7 8 4 chunks +81 lines, -56 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_webview_arm64_aosp_perf_bisect.json View 1 2 3 4 5 6 7 8 4 chunks +81 lines, -56 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_fyi_perf_bisect.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus5X_perf_bisect.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus5_perf_bisect.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus6_perf_bisect.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus7_perf_bisect.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus9_perf_bisect.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_one_perf_bisect.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_s5_perf_bisect.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_s5_perf_cq.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_webview_arm64_aosp_perf_bisect.json View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_fyi_perf_bisect.json View 1 2 3 4 5 6 7 8 7 chunks +87 lines, -62 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5X_perf_bisect.json View 1 2 3 4 5 6 7 8 7 chunks +87 lines, -62 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5_perf_bisect.json View 1 2 3 4 5 6 7 8 7 chunks +87 lines, -62 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus6_perf_bisect.json View 1 2 3 4 5 6 7 8 7 chunks +87 lines, -62 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus7_perf_bisect.json View 1 2 3 4 5 6 7 8 7 chunks +87 lines, -62 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus9_perf_bisect.json View 1 2 3 4 5 6 7 8 7 chunks +87 lines, -62 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_one_perf_bisect.json View 1 2 3 4 5 6 7 8 7 chunks +87 lines, -62 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_bisect.json View 1 2 3 4 5 6 7 8 7 chunks +87 lines, -62 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_cq.json View 1 2 3 4 5 6 7 8 7 chunks +87 lines, -62 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_webview_arm64_aosp_perf_bisect.json View 1 2 3 4 5 6 7 8 7 chunks +87 lines, -62 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.py View 1 2 3 4 1 chunk +44 lines, -15 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_no_benchmark_to_run.json View 1 2 3 4 5 6 7 8 3 chunks +72 lines, -53 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_no_changes.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_run_benchmark.json View 1 2 3 4 5 6 7 8 6 chunks +78 lines, -59 lines 0 comments Download

Messages

Total messages: 34 (20 generated)
Ziqi Xiong
4 years, 5 months ago (2016-06-29 20:23:57 UTC) #3
Ziqi Xiong
Hi Roberto, I think this CQ job CL is ready to commit. Let me know ...
4 years, 5 months ago (2016-07-12 00:29:04 UTC) #6
sullivan
4 years, 5 months ago (2016-07-12 14:52:59 UTC) #8
RobertoCN
This looks good. If the _compile method is no longer used then we should remove ...
4 years, 5 months ago (2016-07-13 23:42:00 UTC) #9
Ziqi Xiong
https://codereview.chromium.org/2104143003/diff/100001/scripts/slave/recipe_modules/perf_try/api.py File scripts/slave/recipe_modules/perf_try/api.py (right): https://codereview.chromium.org/2104143003/diff/100001/scripts/slave/recipe_modules/perf_try/api.py#newcode178 scripts/slave/recipe_modules/perf_try/api.py:178: def _compile(self, name, mastername, buildername, update_step, bot_db): # pragma: ...
4 years, 5 months ago (2016-07-14 00:15:33 UTC) #10
RobertoCN
https://codereview.chromium.org/2104143003/diff/120001/scripts/slave/recipe_modules/perf_try/api.py File scripts/slave/recipe_modules/perf_try/api.py (right): https://codereview.chromium.org/2104143003/diff/120001/scripts/slave/recipe_modules/perf_try/api.py#newcode179 scripts/slave/recipe_modules/perf_try/api.py:179: # We've had some cases where a stale build ...
4 years, 5 months ago (2016-07-14 22:12:54 UTC) #15
Ziqi Xiong
https://codereview.chromium.org/2104143003/diff/120001/scripts/slave/recipe_modules/perf_try/api.py File scripts/slave/recipe_modules/perf_try/api.py (right): https://codereview.chromium.org/2104143003/diff/120001/scripts/slave/recipe_modules/perf_try/api.py#newcode179 scripts/slave/recipe_modules/perf_try/api.py:179: # We've had some cases where a stale build ...
4 years, 5 months ago (2016-07-14 22:44:00 UTC) #16
RobertoCN
Before landing this, please explain in a doc how will we test that this patch ...
4 years, 5 months ago (2016-07-15 23:00:42 UTC) #17
dtu
lgtm
4 years, 5 months ago (2016-07-18 19:23:35 UTC) #18
Ziqi Xiong
On 2016/07/15 23:00:42, RobertoCN wrote: > Before landing this, please explain in a doc how ...
4 years, 5 months ago (2016-07-18 19:56:43 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104143003/140001
4 years, 5 months ago (2016-07-18 19:58:20 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/6253)
4 years, 5 months ago (2016-07-18 20:01:10 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104143003/160001
4 years, 5 months ago (2016-07-18 20:19:48 UTC) #32
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 20:24:54 UTC) #34
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/tools/build/+/f20aae69a5e30a8b3425...

Powered by Google App Engine
This is Rietveld 408576698