Build delegation for CQ jobs

scripts/slave/recipe_modules/perf_try/api.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """API for the perf try job recipe module.
 
 This API is meant to enable the perf try job recipe on any chromium-supported
 platform for any test that can be run via buildbot, perf or otherwise.
 """
 
@@ skipping 94 matching lines @@
   def run_cq_job(self, update_step, bot_db, files_in_patch):
     """Runs benchmarks affected by a CL on CQ."""
     buildername = self.m.properties['buildername']
     affected_benchmarks = self._get_affected_benchmarks(files_in_patch)
     if not affected_benchmarks:
       step_result = self.m.step('Results', [])
       step_result.presentation.step_text = (
           'There are no modifications to Telemetry benchmarks,'
           ' aborting the try job.')
       return
-    self._compile('With Patch', self.m.properties['mastername'],
-                  self.m.properties['buildername'], update_step, bot_db)
+    revision_hash = self.m.properties.get('parent_got_revision')
+    update_step = self._checkout_revision(update_step, bot_db, revision_hash)
+    if update_step.presentation.properties:
+      revision_hash = update_step.presentation.properties['got_revision']
+    revision = build_state.BuildState(self, revision_hash, True)
+    revision.request_build()
+    revision.wait_for()
+    revision.download_build(update_step, bot_db)
 
     if self.m.chromium.c.TARGET_PLATFORM == 'android':
       self.m.chromium_android.adb_install_apk('ChromePublic.apk')
 
     tests = self.m.chromium.list_perf_tests(_get_browser(buildername), 1)
 
     tests = dict((k, v) for k, v in tests.json.output['steps'].iteritems()
                  if _is_benchmark_match(k, affected_benchmarks))
 
     if not tests:
@@ skipping 35 matching lines @@
         self.m.chromium.taskkill()
       self.m.gclient.c.revisions['src'] = str(revision)
       update_step = self.m.bot_update.ensure_checkout(
           suffix=str(revision), force=True, patch=False,
           update_presentation=False)
       assert update_step.json.output['did_run']
       self.m.chromium.runhooks(name='runhooks on %s' % str(revision))
 
     return update_step
 
-  def _compile(self, name, mastername, buildername, update_step, bot_db):
-    """Runs compile and related steps for given builder."""
-    # TODO(phajdan.jr): Change this method to take bot_config as parameter.
-    bot_config = self.m.chromium_tests.create_bot_config_object(
-        mastername, buildername)
-    compile_targets = self.m.chromium_tests.get_compile_targets(
-        bot_config, bot_db, tests=[])
-    if self.m.chromium.c.TARGET_PLATFORM == 'android':
-      self.m.chromium_android.clean_local_files()
-      compile_targets = None
-    else:
-      # Removes any chrome temporary files or build.dead directories.
-      self.m.chromium.cleanup_temp()
-
-    if 'With Patch' in name:
+    if 'With Patch' in name:  # pragma: no cover
       # We've had some cases where a stale build directory was used on perf

[RobertoCN, 2016/07/14 22:12:54]

This removal is incomplete. probably a rebase artifact?

[Ziqi Xiong, 2016/07/14 22:43:59]

Done.

       # try job leading to unwanted cache and temp data. The best way to
       # ensure the old build directory is removed before doing any
       # compilation.
       self.m.file.rmtree(
           'build directory',
           self.m.chromium.c.build_dir.join(self.m.chromium.c.build_config_fs))
       self.m.chromium_tests.transient_check(
           update_step,
           lambda transform_name: self.m.chromium_tests.run_mb_and_compile(
               compile_targets, None, name_suffix=transform_name('')))
@@ skipping 328 matching lines @@
 
 def _prepend_src_to_path_in_command(test_cfg):
   command_to_run = []
   for v in test_cfg.get('command').split():
     if v in ['./tools/perf/run_benchmark',
              'tools/perf/run_benchmark',
              'tools\\perf\\run_benchmark']:
       v = 'src/tools/perf/run_benchmark'
     command_to_run.append(v)
   test_cfg.update({'command': ' '.join(command_to_run)})