Issue 210413003: Drop software resources sent to a GL delegated renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 210413003: Drop software resources sent to a GL delegated renderer.

Created:
6 years, 9 months ago by jbauman

Modified:
6 years, 9 months ago

Reviewers:
danakj

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Drop software resources sent to a GL delegated renderer. The GL renderer can't handle the software resources. BUG=

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -0 lines)			Patch
	M	cc/resources/resource_provider.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
	M	cc/resources/resource_provider_unittest.cc	View	1	1 chunk	+59 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

danakj

can you add a separate TRACE_EVENT for this? it seems like something that will come ...

6 years, 9 months ago (2014-03-25 18:02:10 UTC) #2

jbauman

PTAL. Split this out to add in a different trace event, and added a unit ...

6 years, 9 months ago (2014-03-25 20:38:17 UTC) #3

danakj

6 years, 9 months ago (2014-03-25 21:12:47 UTC) #4

LGTM

https://codereview.chromium.org/210413003/diff/30001/cc/resources/resource_pr...
File cc/resources/resource_provider_unittest.cc (right):

https://codereview.chromium.org/210413003/diff/30001/cc/resources/resource_pr...
cc/resources/resource_provider_unittest.cc:1214: EXPECT_EQ(0u,
resource_provider_->num_resources());
Can you throw a comment in at each step in the test, for example here:

// The parent compositor returns the resource immediately upon receipt.

It helps a lot to read the story of the test in comments when you come back to
it later, or for other readers.

Expand Messages | Collapse Messages