ui/webui/resources/js/cr/ui/tabs.js - Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/tabs.js

Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch file manager test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/webui/resources/js/cr/ui/tabs.js

diff --git a/ui/webui/resources/js/cr/ui/tabs.js b/ui/webui/resources/js/cr/ui/tabs.js

index 512c729444a5f804db85b56be39ee089adf575df..d3256d8f345ac8035511232ad77f0a3e3652d1c4 100644

--- a/ui/webui/resources/js/cr/ui/tabs.js

+++ b/ui/webui/resources/js/cr/ui/tabs.js

@@ -150,13 +150,13 @@ cr.define('cr.ui', function() {

handleKeyDown_: function(e) {

var delta = 0;

- switch (e.keyIdentifier) {

- case 'Left':

- case 'Up':

+ switch (e.key) {

+ case 'ArrowLeft':

+ case 'ArrowUp':

delta = -1;

break;

- case 'Right':

- case 'Down':

+ case 'ArrowRight':

+ case 'ArrowDown':

delta = 1;

break;

}

« no previous file with comments | « ui/webui/resources/js/cr/ui/overlay.js ('k') | ui/webui/resources/js/cr/ui/tree.js » ('j') | no next file with comments »