ui/webui/resources/js/cr/ui/overlay.js - Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/overlay.js

Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch file manager test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/webui/resources/js/cr/ui/overlay.js

diff --git a/ui/webui/resources/js/cr/ui/overlay.js b/ui/webui/resources/js/cr/ui/overlay.js

index 7d02f13999b18a86f24cb277d565316031a5f055..c7b19e614a787b5ca1163c616757609e7558e7d1 100644

--- a/ui/webui/resources/js/cr/ui/overlay.js

+++ b/ui/webui/resources/js/cr/ui/overlay.js

@@ -50,13 +50,13 @@ cr.define('cr.ui.overlay', function() {

return;

// Close the overlay on escape.

- if (e.keyIdentifier == 'U+001B')

+ if (e.key == 'Escape')

cr.dispatchSimpleEvent(overlay, 'cancelOverlay');

// Execute the overlay's default button on enter, unless focus is on an

// element that has standard behavior for the enter key.

var forbiddenTagNames = /^(A|BUTTON|SELECT|TEXTAREA)$/;

- if (e.keyIdentifier == 'Enter' &&

+ if (e.key == 'Enter' &&

!forbiddenTagNames.test(document.activeElement.tagName)) {

var button = getDefaultButton(overlay);

if (button) {

« no previous file with comments | « ui/webui/resources/js/cr/ui/menu_item.js ('k') | ui/webui/resources/js/cr/ui/tabs.js » ('j') | no next file with comments »