[DevTools] Store script source in v8::Global.

[DevTools] Store script source in v8::Global.

This is a preparation step to migrate away from WTF::String in v8_inspector.
To avoid copying the global, this patch moves V8DebuggerScript to the heap.

BUG=580337
Committed: https://crrev.com/50d0615528c167f0dd996dc03598590bfbb6d69f
Cr-Commit-Position: refs/heads/master@{#403320}

[dgozman, 2016-06-28 19:32:31]

dgozman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org, yangguo@chromium.org

[dgozman, 2016-06-28 19:32:32]

Could you please take a look?

[dgozman, 2016-06-28 23:17:06]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-28 23:19:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 23:27:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 23:27:23]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[kozy, 2016-06-29 00:34:05]

https://codereview.chromium.org/2104063002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.h (right):

https://codereview.chromium.org/2104063002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.h:61:
V8DebuggerScript* setScriptId(const String16&);
It looks like we use most part of this setters only in createScript function.
Can we pass scriptId, url, startLine, startColumn, endLine, endColumn,
executionContextId, isContentScript, isInternalScript, isLiveEdit as constructor
arguments and get rid of setters?
And can we calculate hash in constructor?

[dgozman, 2016-06-29 18:58:19]

PTAL

[dgozman, 2016-06-29 18:58:26]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 18:59:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-06-29 19:19:38]

lgtm

[commit-bot: I haz the power, 2016-06-29 20:09:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 20:09:08]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dgozman, 2016-06-30 00:17:35]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-06-30 00:18:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 01:33:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 01:33:52]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dgozman, 2016-06-30 18:57:46]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-06-30 18:58:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 21:17:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 21:17:51]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-06-30 21:33:26]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-06-30 21:34:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 23:01:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-30 23:04:41]

Description was changed from

==========
[DevTools] Store script source in v8::Global.

This is a preparation step to migrate away from WTF::String in v8_inspector.
To avoid copying the global, this patch moves V8DebuggerScript to the heap.

BUG=580337
==========

to

==========
[DevTools] Store script source in v8::Global.

This is a preparation step to migrate away from WTF::String in v8_inspector.
To avoid copying the global, this patch moves V8DebuggerScript to the heap.

BUG=580337

Committed: https://crrev.com/50d0615528c167f0dd996dc03598590bfbb6d69f
Cr-Commit-Position: refs/heads/master@{#403320}
==========

[commit-bot: I haz the power, 2016-06-30 23:04:43]

Patchset 2 (id:??) landed as
https://crrev.com/50d0615528c167f0dd996dc03598590bfbb6d69f
Cr-Commit-Position: refs/heads/master@{#403320}