Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2104053004: Revert of Make 2D canvas disable gpu acceleration when getImageData is called (patchset #6 id:10000… (Closed)

Created:
4 years, 5 months ago by stevenjb
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2782
Target Ref:
refs/pending/branch-heads/2782
Project:
chromium
Visibility:
Public.

Description

Revert of Make 2D canvas disable gpu acceleration when getImageData is called (patchset #6 id:100001 of https://codereview.chromium.org/2063473002/ ) Reason for revert: Causing crash in mailbox release callback - bug 623101 Original issue's description: > Make 2D canvas disable gpu acceleration when getImageData is called > > In order to optimize performance, GPU-accelerated canvases should > permanently switch out of accalerated mode as soon as > getImageData is called. The cost of getImageData on the GPU is > so prohibitively high that it almost always outways the benefit > of acceleration. > > This is the first time we implement a SW/GPU switch that can happen > after the first frame was presented, which may result in a small one > time glitch due to rendering engine discrepancies. Let's see if we get > any complaints about this. If there are complaints, we may inhibit > the switch based on what kind of content was rendered to the canvas. > > BUG=606688 > > Committed: https://crrev.com/33732aec33c88cb18c212544da7d0a4ba53cd9ce > Cr-Commit-Position: refs/heads/master@{#401751} TBR=xlai@chromium.org,xidachen@chromium.org,junov@chromium.org BUG=606688, 623101 Review-Url: https://codereview.chromium.org/2101823002 Cr-Commit-Position: refs/heads/master@{#402391} (cherry picked from commit 27543ee6015a5d358e3abdb6ffb6121f6c847e31)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -165 lines) Patch
M third_party/WebKit/Source/core/html/HTMLCanvasElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 4 chunks +0 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DImageBufferSurface.h View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 chunk +2 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 4 chunks +40 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsTypes.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 3 chunks +1 line, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBufferClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/platform/graphics/test/FakeWebGraphicsContext3DProvider.h View 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
xidachen
4 years, 5 months ago (2016-06-29 12:28:11 UTC) #1
The original CL has been reverted already. Could you please close this issue to
avoid any confusion in the future? Thank you.

Powered by Google App Engine
This is Rietveld 408576698