Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2101823002: Revert of Make 2D canvas disable gpu acceleration when getImageData is called (Closed)

Created:
4 years, 5 months ago by sunnyps
Modified:
4 years, 5 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, blink-reviews-platform-graphics_chromium.org, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis, sebastienlc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make 2D canvas disable gpu acceleration when getImageData is called (patchset #6 id:100001 of https://codereview.chromium.org/2063473002/ ) Reason for revert: Causing crash in mailbox release callback - bug 623101 Original issue's description: > Make 2D canvas disable gpu acceleration when getImageData is called > > In order to optimize performance, GPU-accelerated canvases should > permanently switch out of accalerated mode as soon as > getImageData is called. The cost of getImageData on the GPU is > so prohibitively high that it almost always outways the benefit > of acceleration. > > This is the first time we implement a SW/GPU switch that can happen > after the first frame was presented, which may result in a small one > time glitch due to rendering engine discrepancies. Let's see if we get > any complaints about this. If there are complaints, we may inhibit > the switch based on what kind of content was rendered to the canvas. > > BUG=606688 > > Committed: https://crrev.com/33732aec33c88cb18c212544da7d0a4ba53cd9ce > Cr-Commit-Position: refs/heads/master@{#401751} TBR=xlai@chromium.org,xidachen@chromium.org,junov@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=606688, 623101 Committed: https://crrev.com/27543ee6015a5d358e3abdb6ffb6121f6c847e31 Cr-Commit-Position: refs/heads/master@{#402391}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -165 lines) Patch
M third_party/WebKit/Source/core/html/HTMLCanvasElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 4 chunks +0 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DImageBufferSurface.h View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 chunk +2 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 4 chunks +40 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsTypes.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 3 chunks +1 line, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBufferClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/platform/graphics/test/FakeWebGraphicsContext3DProvider.h View 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
sunnyps
Created Revert of Make 2D canvas disable gpu acceleration when getImageData is called
4 years, 5 months ago (2016-06-28 00:02:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101823002/1
4 years, 5 months ago (2016-06-28 00:03:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 03:41:08 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 03:43:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27543ee6015a5d358e3abdb6ffb6121f6c847e31
Cr-Commit-Position: refs/heads/master@{#402391}

Powered by Google App Engine
This is Rietveld 408576698