Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 210403002: Revert of Update image data upon changing the img.crossorigin attribute. (Closed)

Created:
6 years, 9 months ago by sof
Modified:
6 years, 9 months ago
Reviewers:
adamk, abarth-chromium
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Update image data upon changing the img.crossorigin attribute. (https://codereview.chromium.org/201143002/) Reason for revert: The re-issuing of another image load upon setting 'crossorigin' has been reported to cause a site problem (a Google internal site/service.) Until diagnosed and understood fully, let's back this one out. Original issue's description: > Update image data upon changing the img.crossorigin attribute. > > The spec tells us that setting the crossorigin attribute on an img > element should cause the "update the image data" steps to be invoked, > > http://www.whatwg.org/specs/web-apps/current-work/#update-the-image-data > > Do so here, along with updating the underlying test's expectation. > > R= > BUG=341047 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169382 TBR=adamk@chromium.org,abarth@chromium.org NOTREECHECKS=true NOTRY=true BUG=341047 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -34 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/images/image-with-origin-header.html View 1 chunk +21 lines, -26 lines 0 comments Download
M LayoutTests/http/tests/images/image-with-origin-header-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/resources/origin.php View 1 chunk +15 lines, -3 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sof
Created Revert of Update image data upon changing the img.crossorigin attribute.
6 years, 9 months ago (2014-03-24 20:48:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/210403002/1
6 years, 9 months ago (2014-03-24 20:48:34 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 20:49:03 UTC) #3
Message was sent while issue was closed.
Change committed as 169874

Powered by Google App Engine
This is Rietveld 408576698