Issue 2103983002: Add 'x' button to the signin promo in the password bubble on Mac.

Issue 2103983002: Add 'x' button to the signin promo in the password bubble on Mac. (Closed)

Created:
4 years, 5 months ago by vasilii

Modified:
4 years, 5 months ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add 'x' button to the signin promo in the password bubble on Mac. BUG=615825 Committed: https://crrev.com/6ccdf65d71b01c31371dedbd926deb714dd6ce07 Cr-Commit-Position: refs/heads/master@{#402762}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -3 lines)			Patch
M	chrome/browser/ui/cocoa/passwords/signin_promo_view_controller.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/passwords/signin_promo_view_controller.mm	View	6 chunks	+31 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/passwords/signin_promo_view_controller_unittest.mm	View	2 chunks	+8 lines, -0 lines	0 comments	Download

Total messages: 8 (3 generated)

vabr (Chromium)

Hi Vasilii, LGTM. (Sorry, I'm not sure how I missed this one yesterday.) Cheers, Vaclav

4 years, 5 months ago (2016-06-29 06:38:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103983002/1

4 years, 5 months ago (2016-06-29 08:39:33 UTC) #5

commit-bot: I haz the power

4 years, 5 months ago (2016-06-29 09:25:09 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6ccdf65d71b01c31371dedbd926deb714dd6ce07
Cr-Commit-Position: refs/heads/master@{#402762}