Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: chrome/browser/ui/cocoa/passwords/signin_promo_view_controller_unittest.mm

Issue 2103983002: Add 'x' button to the signin promo in the password bubble on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/passwords/signin_promo_view_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/passwords/signin_promo_view_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/passwords/signin_promo_view_controller_unittest.mm b/chrome/browser/ui/cocoa/passwords/signin_promo_view_controller_unittest.mm
index fcd83c6e215d1ebd2e87e68630bad1b14f0029a2..168c3432642c7c1543339d7bcf99a911e2304dcb 100644
--- a/chrome/browser/ui/cocoa/passwords/signin_promo_view_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/passwords/signin_promo_view_controller_unittest.mm
@@ -74,6 +74,13 @@ TEST_F(SignInPromoViewControllerTest, ClickNo) {
EXPECT_TRUE([delegate() dismissed]);
}
+TEST_F(SignInPromoViewControllerTest, ClickClose) {
+ EXPECT_CALL(*ui_controller(), NavigateToChromeSignIn()).Times(0);
+ [controller().closeButton performClick:nil];
+
+ EXPECT_TRUE([delegate() dismissed]);
+}
+
TEST_F(SignInPromoViewControllerTest, CloseBubbleAndHandleClick) {
// A user may press mouse down, some navigation closes the bubble, mouse up
// still sends the action.
@@ -81,6 +88,7 @@ TEST_F(SignInPromoViewControllerTest, CloseBubbleAndHandleClick) {
[delegate() setModel:nil];
[controller().signInButton performClick:nil];
[controller().noButton performClick:nil];
+ [controller().closeButton performClick:nil];
}
} // namespace
« no previous file with comments | « chrome/browser/ui/cocoa/passwords/signin_promo_view_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698