Changes to Lua gradient scraping

Changes to Lua gradient scraping

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103973002

Committed: https://skia.googlesource.com/skia/+/b4f254e051b375c098c3f1c943b2b0886fec60e1

[fmenozzi, 2016-06-28 17:36:58]

Description was changed from

==========
Changes to Lua gradient scraping

BUG=skia:
==========

to

==========
Changes to Lua gradient scraping

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103973002
==========

[fmenozzi, 2016-06-28 17:39:51]

fmenozzi@google.com changed reviewers:
+ reed@google.com

[fmenozzi, 2016-06-28 17:39:51]

ptal

[reed1, 2016-06-28 17:50:18]

https://codereview.chromium.org/2103973002/diff/1/src/utils/SkLua.cpp
File src/utils/SkLua.cpp (right):

https://codereview.chromium.org/2103973002/diff/1/src/utils/SkLua.cpp#newcode...
src/utils/SkLua.cpp:1272: SkAutoTArray<SkScalar> pos(info.fColorCount);
Can we move these two lines into the if, so we're not allocating if the type is
kNone?

https://codereview.chromium.org/2103973002/diff/1/src/utils/SkLua.cpp#newcode...
src/utils/SkLua.cpp:1296: 
We're not pushing the actual t-values into a table while we're here?

[fmenozzi, 2016-06-28 17:53:35]

On 2016/06/28 17:50:18, reed1 wrote:
> https://codereview.chromium.org/2103973002/diff/1/src/utils/SkLua.cpp
> File src/utils/SkLua.cpp (right):
> 
>
https://codereview.chromium.org/2103973002/diff/1/src/utils/SkLua.cpp#newcode...
> src/utils/SkLua.cpp:1272: SkAutoTArray<SkScalar> pos(info.fColorCount);
> Can we move these two lines into the if, so we're not allocating if the type
is
> kNone?

Yeah I can do that

>
https://codereview.chromium.org/2103973002/diff/1/src/utils/SkLua.cpp#newcode...
> src/utils/SkLua.cpp:1296: 
> We're not pushing the actual t-values into a table while we're here?

So I'm actually not sure how to do that...I briefly glanced over Lua's C API and
I'm not sure how to push an entire table (i.e. array of t values), doubly-so
through Skia's additional API layer.

[fmenozzi, 2016-06-28 19:57:29]

Added revisions, ptal

[reed1, 2016-06-28 20:42:50]

lgtm

[fmenozzi, 2016-06-28 20:46:56]

The CQ bit was checked by fmenozzi@google.com

[commit-bot: I haz the power, 2016-06-28 20:47:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 21:03:05]

Description was changed from

==========
Changes to Lua gradient scraping

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103973002
==========

to

==========
Changes to Lua gradient scraping

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103973002

Committed:
https://skia.googlesource.com/skia/+/b4f254e051b375c098c3f1c943b2b0886fec60e1
==========

[commit-bot: I haz the power, 2016-06-28 21:03:06]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b4f254e051b375c098c3f1c943b2b0886fec60e1

[fmenozzi, 2016-07-11 19:19:07]

Description was changed from

==========
Changes to Lua gradient scraping

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103973002

Committed:
https://skia.googlesource.com/skia/+/b4f254e051b375c098c3f1c943b2b0886fec60e1
==========

to

==========
Changes to Lua gradient scraping

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103973002

Committed:
https://skia.googlesource.com/skia/+/b4f254e051b375c098c3f1c943b2b0886fec60e1
==========

[fmenozzi, 2016-07-11 19:29:34]

fmenozzi@google.com changed reviewers:
+ tomhudson@google.com
- reed@google.com